Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce release size by excluding demos and tests. #86

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

danepowell
Copy link
Contributor

@danepowell danepowell commented Jul 22, 2019

The size of php-htmldiff on disk is 10MB. This may not sound like much, but that could easily make it the single largest package in any given Composer install. This could be easily reduced to <1MB by simply excluding the demos and tests from packaged releases. Anyone who still wants access to those files would still get them by simply cloning from source, but the thousands of other projects simply using this as a library would save a ton of bandwidth and build time. (literally something like 16TB across the 1.6M installs of this project.)

This is an increasingly common pattern for Composer libraries, following the strategy outlined here.

@bobvandevijver
Copy link
Contributor

bobvandevijver commented Jan 28, 2020

In my opinion, before this is merged, the demo css should be made available from another path, as it is an easy to use default CSS styling for anyone using the bundle.

Or, even better, maybe it should be offered as SCSS file.

@jschroed91
Copy link
Member

@danepowell You're very right, we should exclude these for sure. Thanks @bobvandevijver for the note, I agree with that. Will get to this later this week.

@mrflos
Copy link

mrflos commented Sep 27, 2021

Hi @jschroed91 !
Any chance this PR will be merged soon?
We want to use it for an open source project called YesWiki but having a 1mb dependency instead of a 10mb one would be great!

@jschroed91
Copy link
Member

@mrflos Oh, yes let's get this in. I'll take a look after work unless @SavageTiger has any concerns with it, or if he beats me to it

@mrflos mrflos mentioned this pull request Sep 27, 2021
5 tasks
@jschroed91 jschroed91 merged commit 35e31c5 into caxy:master Sep 27, 2021
@jschroed91
Copy link
Member

@mrflos This has been merged and included in release v0.1.13 - thank you @danepowell

@mrflos
Copy link

mrflos commented Sep 28, 2021

Thank you all very very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants