Issue #77: Performance Fixes #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unctions only when necessary
…ime ago, pretty sure that it can be removed
…compare is about 30% faster
This was referenced Feb 13, 2019
|
This is great @SavageTiger! I will take a look at this tonight or tomorrow and if all looks good will get this merged in and a new release tagged |
jschroed91
approved these changes
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Josh,
After reading about all the performance troubles on the Drupal forums and in the issue #77 I thought i'd try to fix it.
Its obvious that introducing multibyte support was the big performance hit, however, it is not needed most of the time.
I realized it is pretty easy to determine if this is the case by comparing the result of
strlen($text)tomb_strlen($text)and enabled / disabled mb_ functions accordingly. And this fixed the issue.I also did some small performance fixes by doing some more strict checking, and making the internal php call graph smaller. Used a profiler to fix these issues (xhprof). However the problem was that by decreasing the call-stack I think my biggest performance improvements came from the profiler having less of a hard time keeping up