Create configuration class for HtmlDiff config options #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschroed91
added a commit
that referenced
this pull request
Mar 9, 2016
Create configuration class for HtmlDiff config options
This was referenced Mar 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new class
Caxy\HtmlDiff\HtmlDiffConfigto house the configuration options for HtmlDiff/ListDiff/TableDiff in an object. We've added a decent amount of config options to the HtmlDiff class, and it's getting quite messy having to pass these options individually into each new instance of ListDiff/TableDiff/HtmlDiff that we end up creating. So now we can just pass the object along!In order to be backwards-compatible, I left the __construct intact as well as the public getter/setter functions for the config options, but I marked them as deprecated.
Use
HtmlDiff::setConfigto set the configuration object. The __construct is currently creating a new instance of HtmlDiffConfig with the default options by default, so you don't actually need to create a new object if you don't want to. You can simply callHtmlDiff::getConfigto get the object and then use the (fluent) setter functions to set configuration options.