deps: Downgrade spl crates for upcoming yank #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem New projects using spl crates are having a hard time because of the flexible dependency on v2 or v1 of the Solana crates -- cargo picks up the highest version of the dependency if there's no lockfile, and downstream users are left with confusing error messages about multiple versions of Solana crates present in the project. To make it easier for new projects, we are yanking a lot of SPL crates that have the flexible dependency, and spl-type-length-value 0.3.1 is one of those. This crate is the only dependency that explicitly uses it. Summary of Changes Downgrade spl-token-2022 to v1 and spl-type-length-value to v0.3.0 to avoid using it. More information at solana-labs/solana-program-library#6897
|
Thanks for this. I'll find some time this week to make sure everything works and merge. |
cavemanloverboy
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
New projects using spl crates are having a hard time because of the flexible dependency on v2 or v1 of the Solana crates -- cargo picks up the highest version of the dependency if there's no lockfile, and downstream users are left with confusing error messages about multiple versions of Solana crates present in the project.
To make it easier for new projects, we are yanking SPL crates that have the flexible dependency, and spl-type-length-value 0.3.1 is one of those.
This crate is the only dependency that explicitly uses it.
Summary of Changes
Downgrade spl-token-2022 to v1 and spl-type-length-value to v0.3.0 to avoid using it.
More information at solana-labs/solana-program-library#6897