Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Skip runner download and install if already installed #446

Merged
merged 1 commit into from
Feb 25, 2022
Merged

feat: Skip runner download and install if already installed #446

merged 1 commit into from
Feb 25, 2022

Conversation

Swsystem-ATuin
Copy link
Contributor

@Swsystem-ATuin Swsystem-ATuin commented Feb 23, 2022 •
edited
Loading

Description

Currently the gitlab runner user data will try to download/run install script then install. This change will allow alternative installation via userdata_pre_install

Migrations required

NO

Verification

Tested without issue using default install and when already installed.

Documentation

pre-commit run fine, no change to terraform inputs or docs required.

@Swsystem-ATuin Swsystem-ATuin marked this pull request as ready for review February 24, 2022 01:37
@Swsystem-ATuin Swsystem-ATuin changed the title WIP: Skip runner download and install if already installed Skip runner download and install if already installed Feb 24, 2022
@npalm npalm self-requested a review February 24, 2022 22:39
@npalm
Copy link
Collaborator

npalm commented Feb 24, 2022

@Swsystem-ATuin thanks aadded to my queue for PR's this weekend

@npalm npalm changed the title Skip runner download and install if already installed feat: Skip runner download and install if already installed Feb 25, 2022
npalm
npalm approved these changes Feb 25, 2022
View reviewed changes
Copy link
Collaborator

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Swsystem-ATuin thx!

@npalm npalm merged commit 54c10f3 into cattle-ops:develop Feb 25, 2022
semantic-releaser bot pushed a commit that referenced this pull request Feb 25, 2022
@semantic-release-bot
chore(release): 4.40.0 [skip ci]
563c9d1 
## [4.40.0](4.39.1...4.40.0) (2022-02-25)

### Features

* Add ASG lifecycle management Lambda function ([#392](#392)) ([5beb9d7](5beb9d7))
* Skip runner download and install if it's already done ([#446](#446)) ([54c10f3](54c10f3))
@semantic-releaser
Copy link
Contributor

🎉 This PR is included in version 4.40.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

npalm pushed a commit that referenced this pull request Mar 7, 2022
@Swsystem-ATuin @npalm
feat: Skip runner download and install if it's already done (#446)
478ea6a 
Co-authored-by: Steve Wilson <[email protected]>
npalm pushed a commit that referenced this pull request May 17, 2022
@Swsystem-ATuin @npalm
feat: Skip runner download and install if it's already done (#446)
6e5fa59 
Co-authored-by: Steve Wilson <[email protected]>
npalm pushed a commit that referenced this pull request May 19, 2022
@Swsystem-ATuin @npalm
feat: Skip runner download and install if it's already done (#446)
9454f6e 
Co-authored-by: Steve Wilson <[email protected]>
@Swsystem-ATuin Swsystem-ATuin deleted the feature/runner_already_installed branch September 14, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npalm npalm npalm approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Swsystem-ATuin @npalm