Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: detail the usage of S3 cache policy #427

Merged
merged 6 commits into from
Dec 30, 2022
Merged

docs: detail the usage of S3 cache policy #427

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4ec35e3
Add remarks to explain traps in the code
kayman-mk Jan 9, 2022
1b3b2a0
Format code
kayman-mk Jan 9, 2022
017d946
Merge branch 'develop' into kayma/code-docs
kayman-mk Aug 6, 2022
53db786
CODE-DOCS
kayman-mk Aug 23, 2022
a113b8a
leave the comment, no code changes
kayman-mk Aug 23, 2022
5e01a1d
CODE-DOCS
kayman-mk Oct 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,9 @@ resource "aws_iam_role_policy_attachment" "user_defined_policies" {
### Policy for the docker machine instance to access cache
################################################################################
resource "aws_iam_role_policy_attachment" "docker_machine_cache_instance" {
/* If the S3 cache adapter is configured to use an IAM instance profile, the
adapter uses the profile attached to the GitLab Runner machine. So do not
use aws_iam_role.docker_machine.name here! See https://docs.gitlab.com/runner/configuration/advanced-configuration.html */
count = var.cache_bucket["create"] || length(lookup(var.cache_bucket, "policy", "")) > 0 ? 1 : 0

role = aws_iam_role.instance.name
Expand Down