Limit iam:PassRole to the role passed #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayman-mk
force-pushed
the
kayma/limit-pass-role
branch
from
9c3ec65 to
0ee37e3
Compare
|
Fix #368 |
semantic-releaser bot
pushed a commit
that referenced
this pull request
Oct 6, 2021
### [4.31.1](4.31.0...4.31.1) (2021-10-06) ### Bug Fixes * Limit iam:PassRole to the role passed ([#376](#376)) ([eb354d0](eb354d0))
|
🎉 This PR is included in version 4.31.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The police iam:PassRole was not limited to a certain role ARN. This caused security warnings by ScoutSuite. This PR limits the policy to the role passed to the docker machine instances. See #368
Migrations required
No
Verification
Tried this configuration in the Hapag-Lloyd Gitlab CI without problems.
Documentation
We use pre-commit to update the Terraform inputs and outputs in the documentation via terraform-docs. Ensure you have installed those components.