Fix layout bug after device rotation #6
Merged
+135
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoheiyokoyama
commented
Sep 30, 2019
| @@ -201,7 +201,7 @@ public final class PageViewController: UIViewController { | |||
| }() | |||
|
|
|||
| coordinator.animate(alongsideTransition: { _ in | |||
| let contentWidth = self.scrollView.bounds.width | |||
| let contentWidth = size.width | |||
There was a problem hiding this comment.
Use transition size because scrollView.boundsmay not be updated in alongsideTransition.
| - inset(for: tabViewLayout.leading).left - tabViewLayout.leading.distance | ||
| - inset(for: tabViewLayout.trailing).right - tabViewLayout.trailing.distance | ||
| let tabViewSize = CGSize(width: tabViewWidth, height: tabViewLayout.height) | ||
| if tabViewSize != tabView.bounds.size { |
There was a problem hiding this comment.
You need to call tabView.highlightCells(withRatio:) after tab view frame calculation is finished (e.g. after device rotation), so execute the process in viewDidLayoutSubviews()
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed layout-bug after device rotation.