Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fontawesome): init #1323

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat(fontawesome): init #1323

wants to merge 9 commits into from

Conversation

trinkey
Copy link
Contributor

@trinkey trinkey commented Sep 17, 2024

🎉 Theme for Font Awesome 🎉

An svg icon library that kinda sucks but not as much as their website's css

💬 Additional Comments 💬

  • this websites uses variables. occasionally.
  • sometimes inline styles redefine variables
  • why are there so many inline styles
  • the inline styles don't stop help

🗒 Checklist 🗒

  • I have read and followed Catppuccin's submission guidelines.
  • I have made a new directory underneath /styles/<name-of-website> containing the contents of the /template directory.
    • I have ensured that the new directory is in lower-kebab-case.
    • I have followed the template and kept the preprocessor as LESS.
  • I have made sure to update the
    userstyles.yml
    file with information about the new userstyle.
  • I have included the following files:
    • catppuccin.user.css - all the CSS for the userstyle, based on the
      template.
    • preview.webp - composite image of all four individual flavor screenshots (taken with the default accent color of mauve) stitched together, generated via Catwalk.

@trinkey trinkey requested a review from a team as a code owner September 17, 2024 23:08
@trinkey
Copy link
Contributor Author

trinkey commented Sep 17, 2024

404 page isn't styled ughhhhhhhhhhhhhh

Copy link
Member

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stuff on https://fontawesome.com/search?ip=classic&s=regular&o=r

image image

In modal on search page

image image (arrow buttons next/previous in modal)

https://docs.fontawesome.com/web/style/rotate:

image

(at bottom)
image

(sidebar active item background)

https://docs.fontawesome.com/web/style/mask:

image

https://docs.fontawesome.com/web/add-icons/upload-icons/icon-design:
image

Header and below text on https://docs.fontawesome.com/ (--sl-color-text-accent is unthemed)

@@ -342,6 +342,13 @@ userstyles:
readme:
app-link: "https://elk.zone"
current-maintainers: [*ryanccn]
fontawesome:
name: Font Awesome
categories: ["development", "photo_and_video"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
categories: ["development", "photo_and_video"]
categories: [development]

@trinkey
Copy link
Contributor Author

trinkey commented Nov 22, 2024

i see your feedback and will work on fixing these things when i have time but i'm like really busy right now, i'll hopefully get these done by tomorrow or saturday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants