fix(home-manager/k9s): support darwin without XDG #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran into a similar issue with lazygit (see #312 ). Would it be easier to maintain this flake if there were an assertion ensuring XDG is enabled rather than sprinkling in darwin checks? |
|
This worked for me as expected on Darwin both with and without xdg. |
k9s expects configuration files on OS X to live in `~/Library/Application Support/k9s` instead of `~/.config.k9s`. This commit handles the case where the module is built for a darwin system with xdg disabled.
alejandro-angulo
changed the title
getchoo
requested changes
Aug 19, 2024
There was a problem hiding this comment.
It would probably be better to follow the upstream module's example here
This should also be formatted with nixfmt-rfc-style
- More closely matches the upstream module in home-manager - Formatted with nixfmt-rfc-style
getchoo
requested changes
Aug 20, 2024
Co-authored-by: seth <[email protected]>
getchoo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
k9s expects configuration files on OS X to live in
~/Library/Application Support/k9sinstead of~/.config.k9s. This commit handles the case where the module is built for a darwin system with xdg disabled.See: #310