-
-
Notifications
You must be signed in to change notification settings - Fork 55
docs: update readme to support new build system #183
docs: update readme to support new build system #183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think adding the $
does more harm then good. Because of the copy button on GitHub code blocks will be impaired.
Also ideally the PR title should be using the conventional commits style. |
@uncenter @isabelroses i added the code that you guys asked for |
maybe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small things here and there, we don't need this to be perfect for our first iteration 👍
We can fix this at merge time, no big deal. This is going to get squashed anyways. |
@nullishamy @uncenter @isabelroses i fixed the issues |
Instead of re-pinging us there is a button under the "Reviewers" tab on the right panel that lets you re-request a review. |
oh yeah i forgot about that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small bits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs merged after #178, so lets wait for that. Otherwise LGTM.
alright |
Co-authored-by: uncenter <[email protected]>
Freezing this PR, no more changes are to be made. We will rework the README further once we release the new major. Subsequent change requests will be ignored. |
alr |
this PR improves and fixes the readme for the new build system