Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unneeded double quotes #9

Merged
merged 1 commit into from
Jul 9, 2024
Merged

refactor: remove unneeded double quotes #9

merged 1 commit into from
Jul 9, 2024

Conversation

injust
Copy link
Contributor

@injust injust commented Jul 2, 2024

https://github.com/dandavison/delta/blob/f5b37173fe88a62e37208a9587a0ab4fec0ef107/manual/src/configuration.md?plain=1#L36:

Note that delta style argument values in ~/.gitconfig should be in double quotes, like --minus-style="syntax #340001". For theme names and other values, do not use quotes as they will be passed on to delta, like theme = Monokai Extended.

https://github.com/dandavison/delta/blob/f5b37173fe88a62e37208a9587a0ab4fec0ef107/themes.gitconfig follows this, e.g. syntax-theme = Vibrant Sunburst and syntax-theme = Monokai Extended.

@injust injust mentioned this pull request Jul 2, 2024
@uncenter
Copy link
Member

uncenter commented Jul 2, 2024

Does this actually resolve any problems, like #7?

@injust
Copy link
Contributor Author

injust commented Jul 2, 2024

No, just a nitpick. I couldn't figure out how to fix #7.

@Anomalocaridid
Copy link
Collaborator

Could you rebase this please?

@injust
Copy link
Contributor Author

injust commented Jul 2, 2024

Rebased and built.

@uncenter
Copy link
Member

uncenter commented Jul 2, 2024

A bunch of other keys could have their quotation "corrected", see https://github.com/dandavison/delta/blob/f5b37173fe88a62e37208a9587a0ab4fec0ef107/themes.gitconfig#L49-L53. In those lines they are only quoting the hex codes by the looks of it.

@Anomalocaridid
Copy link
Collaborator

It also looks like lines like hunk-header-style entirely lack quotation marks. It looks like only hex codes and format strings have quotations.

@injust injust changed the title Remove double quotes around syntax-theme value refactor: Remove unneeded double quotes Jul 5, 2024
@injust injust changed the title refactor: Remove unneeded double quotes refactor: remove unneeded double quotes Jul 5, 2024
@injust
Copy link
Contributor Author

injust commented Jul 5, 2024

Think I got everything.

Built and did a basic git diff test (delta output looks identical).

@Anomalocaridid Anomalocaridid merged commit b88f87a into catppuccin:main Jul 9, 2024
@Anomalocaridid
Copy link
Collaborator

Thank you!

@injust injust deleted the patch-2 branch July 9, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants