-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate gitconfig sections with a newline #11
Conversation
As I have just opened a Whiskers PR you should probably wait until it is merged before making these changes. The diff is annoying to resolve and if my pull request is merged first you will have to redo this anyway. |
Just wanted to make sure it's tracked somewhere, I can rebase once #8 is merged. edit: Okay yeah I see what you mean 😅 I didn't expect it to get merged that quickly! |
When "rebasing" please make sure your changes to the template actually result in the changes you wrote by hand in the output files. You can do this by building the themes with Whiskers, installation instructions available at https://github.com/catppuccin/whiskers#installation. Once you have it installed you can use |
Like @uncenter said, could you please build the theme to test it after you rebase? That is a hard requirement for the PR being merged. |
Rebased and built. n.b. there's an extra trailing newline in |
This comment was marked as outdated.
This comment was marked as outdated.
Oh I see what you mean. I have a fix, one sec. |
Co-authored-by: uncenter <[email protected]>
Looks good now, thanks for the fix! |
No problem. We had a similar issue with another port, will note it down to add that tip to the docs! |
Thank you! |
Edited by hand and didn't build to test.