Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Plasma's SVG cursors implementation #37

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

trowgundam
Copy link
Contributor

@trowgundam trowgundam commented Oct 12, 2024

With the release of Plasma 6.2 comes support for SVG Cursors, so I figured I'd go ahead an implement them since I'm now using Plasma. Luckily this is a much simpler implementation than Hyprcursor was It doesn't require a special utility or anything, so I didn't put it behind a flag. If you want that changed, I should be able to add that fairly easily. Here is a screenshot of the cursor. It's a bit blurry, but that is because I had to screen record doing the mouse shake and then screen shot that, so the slight blurriness is just from my poor quality screen recording. It still looks miles better than the non-SVG version.
Screenshot_20241012_175430

Edit: Here is the blog post that I based this implementation on: https://blog.vladzahorodnii.com/2024/10/06/svg-cursors-everything-that-you-need-to-know-about-them/

@txtsd
Copy link

txtsd commented Oct 13, 2024

I was about to do this myself. Glad I looked here first.

@sgoudham sgoudham self-requested a review October 13, 2024 13:28
Copy link
Contributor

@sgoudham sgoudham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Really appreciate it.

It doesn't require a special utility or anything, so I didn't put it behind a flag. If you want that changed, I should be able to add that fairly easily.

I think that's fine for now since, as you said, it doesn't rely on any external tools. It can be modified to be more modular in the future if need be.

Just one question from me on this PR, do we need to update the documentation at all to mention anything specific for Plasma 6.2 or does it just work out of the box ™️ ?

@sgoudham
Copy link
Contributor

sgoudham commented Oct 14, 2024

I'd also appreciate if someone on Plasma 6.2 could confirm that the built artefact (100MB download link) from this PR works for them.

Perhaps @txtsd?

@trowgundam
Copy link
Contributor Author

Just one question from me on this PR, do we need to update the documentation at all to mention anything specific for Plasma 6.2 or does it just work out of the box ™️ ?

It should just work. Plasma will load the cursor from the "cursors_scalable" folder if present, or fall back to the standard "cursors" folder. No special settings required.

@txtsd
Copy link

txtsd commented Oct 14, 2024

I don't actually run Plasma 😅
I'm just excited about the new standard.

Copy link
Contributor

@sgoudham sgoudham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve, thanks again for the PR!

@sgoudham sgoudham merged commit 4bcb0c1 into catppuccin:main Oct 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants