Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursors not showing sometimes #53

Closed
TheHyperZtar opened this issue Nov 16, 2024 · 6 comments · Fixed by #55
Closed

Cursors not showing sometimes #53

TheHyperZtar opened this issue Nov 16, 2024 · 6 comments · Fixed by #55

Comments

@TheHyperZtar
Copy link

Hi, I've been using catppuccin's cursors and I've noticed that sometimes in apps like gparted, vscode, spotify, some file pickers, etc, the cursor disappears (more evident in gparted) and in others like rofi it appears somewhat cropped sometimes, I've been using them in nixos with hyprland and I've already tried several solutions but none of them worked, other cursors like Bibata's don't have this problem

@use-the-fork
Copy link

+1 here.

@arminius-smh
Copy link

arminius-smh commented Nov 20, 2024

I think the cursor isn't showing on programs running under xwayland on hyprland (all or some idk), I've only noticed it on minecraft and on xeyes to test it

On sway it shows the cursor just fine and with only xcursor theme set on hyprland the cursor also shows, so this seems only to be related to hyprcursor (https://github.com/ndom91/rose-pine-hyprcursor for example works fine, so there must be some difference between this hyprcursor theme and the one from catppuccin)

@arminius-smh
Copy link

arminius-smh commented Nov 20, 2024

:o hyprwm/Hyprland#7335 - issue might also not be related to this theme and is an upstream issue instead? idk anymore

@sgoudham
Copy link
Contributor

The hyprcursor implementation in this repository is not ideal, evident by the number of open issues.

I don't use hyperland so it would require someone to look through the code and try to reimplement support for it in a way that addresses the concerns raised in #31

@arminius-smh
Copy link

Okay, I believe this issue here is related to the usage of pngs instead of svgs, I tried the hyprcursor theme with svgs and my cursor is now shown in xwayland apps

Not sure if the underlying issue has something to do with the pngs here or with Hyprland itself

Sadly I don't know how to fix the concerns in the linked issue/it's also a bit hard to go through and figure out what exactly has to be done to fix it entirely and use svgs again, but fixing that issue with svgs should resolve this one as well, I think

@sgoudham
Copy link
Contributor

The cursors were based on SVGs before. As noted in that issue, @kerichdev found some other issues with it and changed it to PNGs.

We should probably move back to SVGs given that the frequency of issues is now higher than it was before.

Covkie added a commit to Covkie/cursors that referenced this issue Nov 26, 2024
as mentioned in catppuccin#53 (comment).

Effectively rewrite the hyprcursor build system to be data driven, reflecting the other formats. As a result dependency on `hyprcursor-util` & `xcur2png` is gone.
Covkie added a commit to Covkie/cursors that referenced this issue Nov 27, 2024
as mentioned in catppuccin#53 (comment).

Effectively rewrite the hyprcursor build system to be data driven, reflecting the other formats. As a result dependency on `hyprcursor-util` & `xcur2png` is gone.
Covkie added a commit to Covkie/cursors that referenced this issue Nov 27, 2024
as mentioned in catppuccin#53 (comment).

Effectively rewrite the hyprcursor build system to be data driven, reflecting the other formats. As a result dependency on `hyprcursor-util` & `xcur2png` is gone.
sgoudham pushed a commit that referenced this issue Dec 3, 2024
* feat: build hyprcursor with svgs

as mentioned in #53 (comment).

Effectively rewrite the hyprcursor build system to be data driven, reflecting the other formats. As a result dependency on `hyprcursor-util` & `xcur2png` is gone.

* scripts: remove hyprcursor specific commands

#55 (comment)

* fix: properly calculate hyprcursor hotspot

* chore: cleanup

removed unused items
fixed indents

* feat: generate manifest.hl from a template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants