[PR196 0/3] Cleanup of integrated test harness, other small fixes #247
Conversation
…et characters. This fixes output issues in some non-ANSI-compatible contexts.
…nvalid keys in the saved context. Also adding some helper functions to standardize constructing package-specific workspace paths.
|
@wjwwood Here are some pre-req changes before merging in the new execution pipeline. Note that the added tests will fail due to a limitation of the current job server. We could fix the bug, but that job server is being replaced almost completely by the new implementation in a forthcoming PR (in which all tests pass). |
|
These changes look ok, I opened a pr against your branch with some things I noticed while reviewing. There are several other functions which are probably too complicated at this point and should be refactored, but we can tackle them later. Once we iterate on and merge my pr against your branch I think this will be ready for merge. In the future go ahead and push your pr branches to the main repository, that way I can just add commits to pr's. |
…ixup Jbohren forks pre 0.4.0 cleanup fixup
|
Ignore last comment, closed wrong PR. |
jbohren
changed the title
|
@wjwwood Feel free to merge this if it looks good. |
[PR196 0/3] Cleanup of integrated test harness, other small fixes
This PR is a prerequisite to merging PR #196. The main changes in this PR include unifying the integrated test harnesses and adding numerous test cases. This PR also involves a few small additions, bugfixes, and cleanup. This PR is a prerequisite to the first segment of PR#196 (new execution pipeline).
The individual changes to the different components of
catkin_toolsare broken up into six atomic commits. Note that commit 8e2df65 only appears to be large due to re-indenting into a try-catch block. In the future,catkin_tools/commands/catkin.pycould use some additional cleanup and refactoring.