Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elapsed time does not format correctly when when greater than one hour and minutes are zero #356

Closed
tfoote opened this issue Apr 22, 2016 · 4 comments · Fixed by #357
Closed

Comments

@tfoote
Copy link
Contributor

tfoote commented Apr 22, 2016

System Info

Build / Run Issue

The timer in the bottom left corner counting elapsed time.

When it gets to 1 hours, for the first minute it counts hh:ss.s where it should be hh:mm:ss.s when mm should read 00

Expected Behavior

It should not collapse the zero minutes field out of site.

Steps to Reproduce the Issue

Run a build for an hour and look at the displayed elapsed time between the 60th and 61st minute of running.

@jbohren jbohren added the bug label Apr 22, 2016
@jbohren
Copy link
Contributor

jbohren commented Apr 22, 2016

Run a build for an hour and look at the displayed elapsed time between the 60th and 61st minute of running.

@tfoote I really hope you weren't staring at it for each of the first 60 minutes.

@jbohren jbohren added this to the 0.4.x - Beta 2 Patches milestone Apr 22, 2016
@tfoote
Copy link
Contributor Author

tfoote commented Apr 22, 2016

But it's so colorful I can't help but watch it....

Good luck reproducing it quickly ;-)

@NikolausDemmel
Copy link
Member

There is always date -s "..." 😎

jbohren added a commit that referenced this issue Apr 22, 2016
jbohren added a commit that referenced this issue Apr 22, 2016
@jbohren
Copy link
Contributor

jbohren commented Apr 22, 2016

Good luck reproducing it quickly ;-)

See #357 😵

from catkin_tools.common import format_time_delta_short as ftds
ftds(3601)

wjwwood added a commit that referenced this issue Apr 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants