Skip to content

Commit

Permalink
Disable metrics cops
Browse files Browse the repository at this point in the history
The auto-generated rubocop config file sets the limit at whatever the
maximum offense is at the time it is created. This is frequently causing
Travis builds for pull requests to fail, when the pull requests aren't
really affecting the code quality.

810979a made the rubocop config change in `.rubocop_todo.yml`, but it
should have been made in `.rubocop.yml`.
  • Loading branch information
michaeljb committed Mar 8, 2016
1 parent 02f43ec commit 292a070
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 34 deletions.
21 changes: 21 additions & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,24 @@ Lint/RescueException:
# lib/vSphere/util/vim_helpers.rb to continue rescuing Exception in that
# method
- 'lib/vSphere/util/vim_helpers.rb'

Metrics/AbcSize:
Enabled: false

Metrics/ClassLength:
Enabled: false

Metrics/CyclomaticComplexity:
Enabled: false

Metrics/LineLength:
Enabled: false

Metrics/MethodLength:
Enabled: false

Metrics/ModuleLength:
Enabled: false

Metrics/PerceivedComplexity:
Enabled: false
48 changes: 14 additions & 34 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# This configuration was generated by `rubocop --auto-gen-config`
# on 2015-09-02 10:38:06 -0600 using RuboCop version 0.32.1.
# on 2016-03-08 11:29:21 -0700 using RuboCop version 0.32.1.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
Expand All @@ -9,40 +9,14 @@
Lint/NonLocalExitFromIterator:
Enabled: false

# Offense count: 11
Metrics/AbcSize:
Enabled: false # Max: 120

# Offense count: 1
# Configuration parameters: CountComments.
Metrics/ClassLength:
Enabled: false # Max: 169

# Offense count: 3
Metrics/CyclomaticComplexity:
Enabled: false # Max: 18

# Offense count: 108
# Configuration parameters: AllowURI, URISchemes.
Metrics/LineLength:
Enabled: false # Max: 177

# Offense count: 12
# Configuration parameters: CountComments.
Metrics/MethodLength:
Enabled: false # Max: 60

# Offense count: 1
# Configuration parameters: CountComments.
Metrics/ModuleLength:
Enabled: false # Max: 162
# Offense count: 24
Style/Documentation:
Enabled: false

# Offense count: 3
Metrics/PerceivedComplexity:
Enabled: false # Max: 19

# Offense count: 25
Style/Documentation:
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
Style/EmptyLinesAroundBlockBody:
Enabled: false

# Offense count: 1
Expand All @@ -56,7 +30,7 @@ Style/EmptyLiteral:
Style/FirstParameterIndentation:
Enabled: false

# Offense count: 5
# Offense count: 6
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues.
Style/HashSyntax:
Expand All @@ -74,6 +48,12 @@ Style/RegexpLiteral:
Style/SpaceAroundOperators:
Enabled: false

# Offense count: 1
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
Style/StringLiterals:
Enabled: false

# Offense count: 4
# Cop supports --auto-correct.
Style/SymbolLiteral:
Expand Down

0 comments on commit 292a070

Please sign in to comment.