Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(QTM-696): Avoiding passing props from the Carousel and Modal components to the Card component #557

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

MarcosViniciusPC
Copy link
Contributor

Description

https://jirasoftware.catho.com.br/browse/QTM-696

Review guide

  • Unit tests (yarn test:components)
  • Regression
  • Doc
  • Code review

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@alizeleal alizeleal added status:reviewing Someone is reviewing this PR and removed status:ready to review labels Apr 25, 2024
@MarcosViniciusPC MarcosViniciusPC added status:pending review status:reviewing Someone is reviewing this PR and removed status:reviewing Someone is reviewing this PR status:pending review labels Apr 25, 2024
Copy link
Contributor

@alizeleal alizeleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review guide

  • Unit tests (yarn test:components)
  • Regression
  • Doc
  • Code review

@alizeleal alizeleal added status:approved and removed status:reviewing Someone is reviewing this PR labels Apr 26, 2024
@MarcosViniciusPC MarcosViniciusPC merged commit 9b503a0 into beta Apr 26, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the QTM-696 branch April 26, 2024 19:26
Copy link

🎉 This PR is included in version 10.0.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants