fix(QTM-645): Nested syntax handling to maintain compatibility with styled components v6 #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponents version 6
|
rapahaeru
approved these changes
Apr 3, 2024
Right. The task https://jirasoftware.catho.com.br/browse/QTM-406 is still in the backlog so we can assess what the problem was |
1 similar comment
Right. The task https://jirasoftware.catho.com.br/browse/QTM-406 is still in the backlog so we can assess what the problem was |
m4ur1c10
approved these changes
Apr 3, 2024
santanasara
approved these changes
Apr 3, 2024
|
🎉 This PR is included in version 9.24.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://jirasoftware.catho.com.br/browse/QTM-645
Review guide
- first start the storybook for regression tests(and keep it open):
yarn test:regression:storybook;- then run the regression tests:
yarn test:regressionHow to test the build
Clone quantum repo
In quantum, run:
yarn && yarn buildIn recruiter-experience_talent-selection_app, run:
npm install ../quantum/distThe above command will work if the quantum project is in the same directory as the recruiter-experience_talent-selection_app project. If not, replace '..' with the relative path of the Quantum project
Browsers review
##Explanation of the problem
The problem was caused by the version of styled components used in the application.
Version 6 of styled components changed the way it handles selectors and pseudo-classes. If pseudo-classes are applied to elements without the "&" prefix, the pseudo-classes will be compiled into descendant styles of the desired element and not as the style of the element itself. More details at https://styled-components.com/docs/faqs#nested-syntax-handling.