Merge pull request #574 from catho/QTM-666

ci(QTM-666): Updated actions/checkout and setup-node to node v20 support
catho · Jul 17, 2024 · f7328c5 · f7328c5
2 parents 95d5cf3 + 0e2a61b
commit f7328c5
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 25 deletions.
diff --git a/.github/workflows/actions-development.yml b/.github/workflows/actions-development.yml
@@ -7,24 +7,21 @@ jobs:
     runs-on: ubuntu-20.04
 
     steps:
-      - uses: actions/checkout@v3
-      - name: Read .nvmrc
-        run: echo NVMRC=$(cat .nvmrc) >> $GITHUB_OUTPUT
-        id: nvm
+      - uses: actions/checkout@v4
 
       - name: Setup node
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
-          node-version: '${{ steps.nvm.outputs.NVMRC }}'
+          node-version-file: '.nvmrc'
 
       - name: Install the dependencies
         run: yarn
 
-      - name: run storybook
+      - name: Run storybook
         run: yarn storybook --smoke-test
 
-      - name: run unit tests
+      - name: Run unit tests
         run: yarn test:components
 
-      - name: run the regression tests
+      - name: Run the regression tests
         run: yarn build:regression
diff --git a/.github/workflows/actions-publish.yml b/.github/workflows/actions-publish.yml
@@ -11,57 +11,55 @@ jobs:
     runs-on: ubuntu-20.04
 
     steps:
-      - uses: actions/checkout@v3
-      - name: Read .nvmrc
-        run: echo NVMRC=$(cat .nvmrc) >> $GITHUB_OUTPUT
-        id: nvm
+      - uses: actions/checkout@v4
 
       - name: Setup node
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
-          node-version: '${{ steps.nvm.outputs.NVMRC }}'
+          node-version-file: '.nvmrc'
 
       - name: Install the dependencies
         run: yarn
 
-      - name: run storybook
+      - name: Run storybook
         run: yarn storybook --smoke-test
 
-      - name: run unit tests
+      - name: Run unit tests
         run: yarn test:components
 
-      - name: run the regression tests
+      - name: Run the regression tests
         run: yarn build:regression
 
   publish:
     needs: tests
     runs-on: ubuntu-20.04
 
     steps:
-      - uses: actions/checkout@v3
-      - name: Read .nvmrc
-        run: echo NVMRC=$(cat .nvmrc) >> $GITHUB_OUTPUT
-        id: nvm
+      - uses: actions/checkout@v4
 
       - name: Setup node
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
-          node-version: '${{ steps.nvm.outputs.NVMRC }}'
+          node-version-file: '.nvmrc'
 
       - name: Install the dependencies
         run: yarn
+
       - name: Build
         run: yarn build
-      - name: setting npm token
+
+      - name: Setting NPM token
         run: ./scripts/publish.sh
         env:
           NPM_TOKEN: ${{secrets.NPM_TOKEN}}
+
       - name: Publish package
         run: yarn semantic-release
         env:
           NPM_TOKEN: ${{secrets.NPM_TOKEN}}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           GH_URL: 'https://api.github.com/'
+
       - name: Deploy storybook to Github Pages
         if: ${{ github.ref == 'refs/heads/master' }}
         run: yarn deploy-storybook -- --ci