test(menu): improves test by removing unecessary id

improves test by using role instead of id
catho · Apr 30, 2024 · 5d33faf · 5d33faf
1 parent d001939
commit 5d33faf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/components/Menu/Menu.jsx b/components/Menu/Menu.jsx
@@ -38,8 +38,6 @@ const Menu = (props) => {
   };
   return (
     <MaterialMenu
-      id="menu"
-      data-testid="menu"
       theme={materialThemeOverride}
       aria-labelledby="button"
       anchorReference="anchorEl"

diff --git a/components/Menu/Menu.unit.test.jsx b/components/Menu/Menu.unit.test.jsx
@@ -57,13 +57,13 @@ describe('<Menu />', () => {
   });
 
   it('does not render with anchorEl when open is false', () => {
-    const { queryByTestId } = renderMenu({
+    const { queryByRole } = renderMenu({
       open: false,
       items: mockItems,
       anchorEl: mockAnchorEl,
       onClose: mockHandleClose,
     });
-    const menu = queryByTestId('menu');
+    const menu = queryByRole('presentation');
     expect(menu).toBeNull();
   });