chore[534] updated createIrsPolicyIfMissing() #934

ds-ashanmugavel · 2024-01-23T10:19:39Z

resolves eclipse-tractusx#534

github-actions

Please add a short description of the feature/fix to the Changelog.md.

github-actions · 2024-01-23T10:23:13Z

Integration Test Results

323 tests 323 ✅ 1m 12s ⏱️
37 suites 0 💤
37 files 0 ❌

Results for commit 7f3cd9a.

♻️ This comment has been updated with latest results.

github-actions · 2024-01-23T10:23:20Z

Unit Test Results

217 tests 217 ✅ 45s ⏱️
55 suites 0 💤
55 files 0 ❌

Results for commit 7f3cd9a.

♻️ This comment has been updated with latest results.

github-actions · 2024-01-23T10:24:48Z

‼️ Dependency Check findings ‼️

One or more high/critical findings have been found during dependency check. Please check the depenency report:
https://github.com/catenax-ng/tx-traceability-foss/actions/runs/7712800939

# Conflicts: # CHANGELOG.md

already updated changelog

ds-lcapellino · 2024-01-23T13:02:45Z

...c/main/java/org/eclipse/tractusx/traceability/assets/infrastructure/base/irs/IrsService.java

-        boolean missingPolicy = irsPolicies.stream().noneMatch(irsPolicy -> irsPolicy.policyId().equals(traceabilityProperties.getRightOperand()));
-        if (missingPolicy) {
+                    if (orMatch || andMatch) {
+                        checkAndUpdatePolicy(irsPolicies);


Let's try to refactor this method to accept only the filtered Policy

…lish-assets' into feature/534-get-policies-and-publish-assets

# Conflicts: # CHANGELOG.md

ds-lcapellino · 2024-01-30T14:28:25Z

.../eclipse/tractusx/traceability/assets/infrastructure/repository/rest/irs/IrsServiceTest.java

@@ -124,7 +124,7 @@ void givenNoPolicyExist_whenCreateIrsPolicyIfMissing_thenCreateIt() {
    @Test


please update the license here

# Conflicts: # CHANGELOG.md

ds-lcapellino

lgtm

sonarqubecloud · 2024-01-30T14:40:17Z

Quality Gate passed for 'Trace-X Root'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
81.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud · 2024-01-30T14:40:34Z

Quality Gate passed for 'TX Traceability FOSS frontend'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

feature: #837 use digitalTwinType for shell lookup, #603 upgrade aspect models

chore[534] updated createIrsPolicyIfMissing()

812c7f3

github-actions bot previously requested changes Jan 23, 2024

View reviewed changes

ashanmugavel and others added 3 commits January 23, 2024 12:29

chore[534] updated CHANGELOG.md

c3a6e9c

Merge branch 'main' into feature/534-get-policies-and-publish-assets

11bda56

# Conflicts: # CHANGELOG.md

feature: 534 update copyright header; use right operand as policy id

46c3573

ds-lcapellino reviewed Jan 23, 2024

View reviewed changes

ds-lcapellino and others added 4 commits January 23, 2024 14:03

Merge remote-tracking branch 'origin/feature/534-get-policies-and-pub…

426801d

…lish-assets' into feature/534-get-policies-and-publish-assets

chore[534] updated methods

45b8318

Merge remote-tracking branch 'origin/feature/534-get-policies-and-pub…

2e17650

…lish-assets' into feature/534-get-policies-and-publish-assets

Merge branch 'main' into feature/534-get-policies-and-publish-assets

7f3cd9a

# Conflicts: # CHANGELOG.md

ds-lcapellino reviewed Jan 30, 2024

View reviewed changes

ashanmugavel added 2 commits January 30, 2024 15:34

chore[534] updated License

b4f895a

Merge branch 'main' into feature/534-get-policies-and-publish-assets

01d0a14

# Conflicts: # CHANGELOG.md

ds-lcapellino approved these changes Jan 30, 2024

View reviewed changes

ds-ashanmugavel merged commit 69d283d into main Jan 30, 2024

ds-ashanmugavel deleted the feature/534-get-policies-and-publish-assets branch January 30, 2024 14:39

ds-mwesener added a commit that referenced this pull request May 2, 2024

Merge pull request #934 from catenax-ng/main

e14d2bf

feature: #837 use digitalTwinType for shell lookup, #603 upgrade aspect models

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore[534] updated createIrsPolicyIfMissing() #934

chore[534] updated createIrsPolicyIfMissing() #934

ds-ashanmugavel commented Jan 23, 2024 •

edited by github-actions bot

Loading

github-actions bot left a comment

github-actions bot commented Jan 23, 2024 •

edited

Loading

github-actions bot commented Jan 23, 2024 •

edited

Loading

github-actions bot commented Jan 23, 2024 •

edited

Loading

ds-lcapellino Jan 23, 2024

ds-lcapellino Jan 30, 2024

ds-lcapellino left a comment

sonarqubecloud bot commented Jan 30, 2024

sonarqubecloud bot commented Jan 30, 2024

		@@ -124,7 +124,7 @@ void givenNoPolicyExist_whenCreateIrsPolicyIfMissing_thenCreateIt() {
		@Test

chore[534] updated createIrsPolicyIfMissing() #934

chore[534] updated createIrsPolicyIfMissing() #934

Conversation

ds-ashanmugavel commented Jan 23, 2024 • edited by github-actions bot Loading

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 23, 2024 • edited Loading

Integration Test Results

github-actions bot commented Jan 23, 2024 • edited Loading

Unit Test Results

github-actions bot commented Jan 23, 2024 • edited Loading

‼️ Dependency Check findings ‼️

ds-lcapellino Jan 23, 2024

Choose a reason for hiding this comment

ds-lcapellino Jan 30, 2024

Choose a reason for hiding this comment

ds-lcapellino left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Jan 30, 2024

Quality Gate passed for 'Trace-X Root'

sonarqubecloud bot commented Jan 30, 2024

Quality Gate passed for 'TX Traceability FOSS frontend'

ds-ashanmugavel commented Jan 23, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Jan 23, 2024 •

edited

Loading

github-actions bot commented Jan 23, 2024 •

edited

Loading

github-actions bot commented Jan 23, 2024 •

edited

Loading