-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NOT-CX-Release] Created er diagram internal datamodel for Trace-X with PUML #697
Conversation
…s-cutting corrected wrong relations between entities and attributes
[Trace-X Root] Kudos, SonarCloud Quality Gate passed! |
[TX Traceability FOSS frontend] Kudos, SonarCloud Quality Gate passed! |
Hi @ds-jleyh the ERM seems not to be correct. When looking into your uml I see relationships from assets_as_built but not for assets_as_planned. As the two entities have same relationships this is wrong. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address feedback.
manufacturer_name : varchar(255) | ||
van : varchar(255) | ||
semantic_model_id : varchar(255) | ||
catenax_site_id : varchar(255) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion:
Consider renaming to
catenax_site_id : varchar(255) | |
catena_x_site_id : varchar(255) |
This leads to the (correct) attribute name catenaXSiteId
after JPA default mapping according to https://github.com/eclipse-tractusx/sldt-semantic-models/blob/main/io.catenax.part_site_information_as_planned/1.0.0/PartSiteInformationAsPlanned.ttl#L77
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are apparently several spellings for the attribute, clarification requested:
eclipse-tractusx/sldt-semantic-models#470
@ds-ashanmugavel / @ds-jleyh please give a short information if you keep working on that pull request or not. If not please close this pr with comment. |
Hi @ds-mwesener , @ds-ashanmugavel is currently working on this task but on a different branch. Therefore, I will close this PR. Thanks for asking. |
IRS-Update & Smaller improvements
Please check the following things I noticed: