Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOT-CX-Release] Created er diagram internal datamodel for Trace-X with PUML #697

Closed
wants to merge 2 commits into from

Conversation

ds-jleyh
Copy link

Please check the following things I noticed:

  • why are there SQL statements as comments in the SQL Script? (tx-backend/src/main/resources/db/migration/V1__base_sql_configuration.sql)
  • Some attributes are written with quotation marks, is this intended? (e.g. in file: tx-backend/src/main/resources/db/migration/V1__base_sql_configuration.sql table: public.assets_as_planned attribute: "owner")
  • Perhaps we need to insert "include" in order to add the diagram to our documentation
  • Please check if I've done the table relations correctly

@github-actions
Copy link

Integration Test Results

215 tests   215 ✔️  1m 47s ⏱️
  32 suites      0 💤
  32 files        0

Results for commit 484b8f6.

@github-actions
Copy link

Unit Test Results

225 tests   222 ✔️  25s ⏱️
  54 suites      3 💤
  54 files        0

Results for commit 484b8f6.

@sonarqubecloud
Copy link

[Trace-X Root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[TX Traceability FOSS frontend] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ds-mwesener
Copy link

Please check the following things I noticed:

  • why are there SQL statements as comments in the SQL Script? (tx-backend/src/main/resources/db/migration/V1__base_sql_configuration.sql)
  • Some attributes are written with quotation marks, is this intended? (e.g. in file: tx-backend/src/main/resources/db/migration/V1__base_sql_configuration.sql table: public.assets_as_planned attribute: "owner")
  • Perhaps we need to insert "include" in order to add the diagram to our documentation
  • Please check if I've done the table relations correctly

Hi @ds-jleyh the ERM seems not to be correct. When looking into your uml I see relationships from assets_as_built but not for assets_as_planned. As the two entities have same relationships this is wrong.
There are also some other issues related to relations.
The entities with attributes seems to be fine for me in the first look.

Copy link

@ds-mwesener ds-mwesener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address feedback.

manufacturer_name : varchar(255)
van : varchar(255)
semantic_model_id : varchar(255)
catenax_site_id : varchar(255)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:

Consider renaming to

Suggested change
catenax_site_id : varchar(255)
catena_x_site_id : varchar(255)

This leads to the (correct) attribute name catenaXSiteId after JPA default mapping according to https://github.com/eclipse-tractusx/sldt-semantic-models/blob/main/io.catenax.part_site_information_as_planned/1.0.0/PartSiteInformationAsPlanned.ttl#L77

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are apparently several spellings for the attribute, clarification requested:
eclipse-tractusx/sldt-semantic-models#470

@ds-mwesener ds-mwesener changed the title Created er diagram internal datamodel for Trace-X with PUML [NOT-CX-Release] Created er diagram internal datamodel for Trace-X with PUML Nov 22, 2023
@ds-mwesener
Copy link

@ds-ashanmugavel / @ds-jleyh please give a short information if you keep working on that pull request or not. If not please close this pr with comment.

@ds-jleyh
Copy link
Author

Hi @ds-mwesener ,

@ds-ashanmugavel is currently working on this task but on a different branch. Therefore, I will close this PR. Thanks for asking.

@ds-jleyh ds-jleyh closed this Nov 27, 2023
@ds-jleyh ds-jleyh deleted the TRI-XXX-add-er-diagram-internal-datamodel branch November 27, 2023 08:33
ds-mwesener pushed a commit that referenced this pull request Feb 22, 2024
IRS-Update & Smaller improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants