Skip to content

Commit

Permalink
Merge pull request #1043 from catenax-ng/chore/625-remove-header-section
Browse files Browse the repository at this point in the history
chore(contracts): 625 removed breadcrumbs and header section from layout
  • Loading branch information
ds-mwesener authored Mar 7, 2024
2 parents 6d95d7c + 2ad088f commit c5ac140
Show file tree
Hide file tree
Showing 11 changed files with 6 additions and 316 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ _**For better traceability add the corresponding GitHub issue number in each cha
- Updated RELEASE.md to the latest release guide (added more steps)
- #515 Fixed notification toast click area

### Removed
- #625 Removed the header and breadcrumbs section from app layout

## [10.6.0 - 04.03.2024]

### Added
Expand Down
10 changes: 0 additions & 10 deletions frontend/src/app/modules/core/layout/header/header.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -41,16 +41,6 @@
<app-user-navigation></app-user-navigation>
</div>
</nav>

<div class="header--breadcrumb-container">
<app-breadcrumbs></app-breadcrumbs>
</div>

<div *ngIf="activeMenu" class="header--app-header">
<h3>{{ 'pageTitle.' + activeMenu | i18n }}</h3>
</div>

<img src="/assets/images/header-subtract.png" class="header--stylish-curve" alt="" />
</div>

<ng-template let-type="value" let-role="role" #menuItem>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ describe('LayoutComponent', () => {
imports: [ LayoutModule ],
providers: [ LayoutComponent ],
});
let header = fixture.debugElement.query(By.css('.header--breadcrumb-container'));
let header = fixture.debugElement.query(By.css('.layout-content__box-modal'));
expect(header).not.toBeNull();
let toast = fixture.debugElement.query(By.css('.layout-toast-component'));
let headerDistanceToTop = header.nativeElement.getBoundingClientRect().y + 'px';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ export class LayoutComponent {
* This Block positions the toast component to the start of the header breadcrumb component (vertical top distance)
* so that on every screen size the position stays the same (not relative)
*/
const headerBreadCrumbRef = this.elementRef.nativeElement.querySelector('.header--breadcrumb-container');
const layoutContentRef = this.elementRef.nativeElement.querySelector('.layout-content__box-modal');
const toastLayoutRef = this.elementRef.nativeElement.querySelector('.layout-toast-component');
const elementTopDistance = headerBreadCrumbRef.getBoundingClientRect().top;
const elementTopDistance = layoutContentRef.getBoundingClientRect().top;
this.renderer.setStyle(toastLayoutRef, 'top', `${ elementTopDistance }px`);
}

Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion frontend/src/app/modules/shared/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ export { Tree } from './modules/relations/presentation/tree/tree.d3';
export { CardIconComponent } from './components/card-icon/card-icon.component';
export { CardListComponent } from './components/card-list/card-list.component';
export { AvatarComponent } from './components/avatar/avatar.component';
export { BreadcrumbsComponent } from './components/breadcrumbs/breadcrumbs.component';
export { ButtonComponent } from './components/button/button.component';
export { ToastContainerComponent } from './components/toasts/toast-container/toast-container.component';
export { ToastMessage } from './components/toasts/toast-message/toast-message.model';
Expand Down
3 changes: 0 additions & 3 deletions frontend/src/app/modules/shared/shared.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ import { FormatPartlistSemanticDataModelToCamelCasePipe } from '@shared/pipes/fo
import { I18NextModule } from 'angular-i18next';
import { BaseInputComponent } from './abstraction/baseInput/baseInput.component';
import { AvatarComponent } from './components/avatar/avatar.component';
import { BreadcrumbsComponent } from './components/breadcrumbs/breadcrumbs.component';
import { ButtonComponent } from './components/button/button.component';
import { CardIconComponent } from './components/card-icon/card-icon.component';
import { CardListComponent } from './components/card-list/card-list.component';
Expand Down Expand Up @@ -83,7 +82,6 @@ import { TemplateModule } from './template.module';
ToastContainerComponent,
PartsTableComponent,
ToastMessageComponent,
BreadcrumbsComponent,
ButtonComponent,
TextWithIconComponent,
TableComponent,
Expand Down Expand Up @@ -134,7 +132,6 @@ import { TemplateModule } from './template.module';
exports: [
ToastContainerComponent,
ToastMessageComponent,
BreadcrumbsComponent,
ButtonComponent,
TextWithIconComponent,
TableComponent,
Expand Down

0 comments on commit c5ac140

Please sign in to comment.