Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(impl):[#558] SingleLevelBomAsPlanned 3.0.0 support, tests updated #896

Merged
merged 3 commits into from
Apr 29, 2024
Merged

feat(impl):[#558] SingleLevelBomAsPlanned 3.0.0 support, tests updated #896

merged 3 commits into from
Apr 29, 2024

Conversation

ds-ext-kmassalski
Copy link

  • SingleLevelBomAsPlanned 3.0.0 support
  • Compatibility Matrix cleanup

@catenax-ng catenax-ng deleted a comment from github-actions bot Apr 26, 2024
ds-jhartmann
ds-jhartmann reviewed Apr 29, 2024
View reviewed changes
Copy link

@ds-jhartmann ds-jhartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good but do we need both testdata json files?

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ds-jhartmann
ds-jhartmann approved these changes Apr 29, 2024
View reviewed changes
Copy link

@ds-jhartmann ds-jhartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ds-ext-kmassalski ds-ext-kmassalski merged commit 1150e9e into main Apr 29, 2024
@ds-ext-kmassalski ds-ext-kmassalski deleted the feat/slbap-3-support-and-tests-updated branch April 29, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ds-jhartmann ds-jhartmann ds-jhartmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ds-ext-kmassalski @ds-jhartmann