feat(impl):[#359] update registry impl for lookup #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
…-for-lookup' into feature/359-registry-update-impl-for-lookup
…for-lookup # Conflicts: # CHANGELOG.md
dsmf
suggested changes
Mar 27, 2024
| return Base64.getEncoder().encodeToString(serialize(globalAssetId)); | ||
| } | ||
|
|
||
| private static byte[] serialize(final IdentifierKeyValuePair assetIds) { |
There was a problem hiding this comment.
This serialization code is duplicated in several places now. My suggestion would be to extract this to a SerializationHelper class and also write a test for it. Then it can safely be reused in every place where it is needed.
| mapper.setSerializationInclusion(JsonInclude.Include.NON_NULL); | ||
| WRITER = mapper.writer(); | ||
| } | ||
|
|
There was a problem hiding this comment.
if the serialization code is extracted to a SerializationHelper (see comment further above, the DecentralDigitalTwinRegistryClient stays cleaner because lines 57 to 64 could be removed here.
|
dsmf
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
story: eclipse-tractusx#359