Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#344 integration tests #744

Merged
merged 23 commits into from
Feb 2, 2024
Merged

Feature/#344 integration tests #744

merged 23 commits into from
Feb 2, 2024

Conversation

ds-jhartmann
Copy link

No description provided.

ds-jhartmann and others added 11 commits January 18, 2024 14:43
@github-actions GitHub Actions
Copy link

CHANGELOG file was not updated! Make sure to include important changes.

@ds-jhartmann
Copy link
Author

IP Lab issue created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/12941

@ds-jhartmann ds-jhartmann marked this pull request as ready for review January 30, 2024 13:56
@ds-jhartmann ds-jhartmann mentioned this pull request Jan 30, 2024
Closed
2 tasks
ds-psosnowski
ds-psosnowski suggested changes Jan 31, 2024
View reviewed changes
Copy link

@ds-psosnowski ds-psosnowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor considerations

irs-api/src/test/java/org/eclipse/tractusx/irs/IrsWireMockIntegrationTest.java Show resolved Hide resolved
irs-api/src/test/java/org/eclipse/tractusx/irs/WireMockTestConfig.java Outdated Show resolved Hide resolved
irs-api/src/test/java/org/eclipse/tractusx/irs/bpdm/BpdmWiremockTest.java Outdated Show resolved Hide resolved
ds-psosnowski
ds-psosnowski previously approved these changes Feb 2, 2024
View reviewed changes
Copy link

@ds-psosnowski ds-psosnowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please only consider adding task number to code in comment :)

@dsmf
Copy link

dsmf commented Feb 2, 2024

Looks very nice!

dsmf
dsmf previously approved these changes Feb 2, 2024
View reviewed changes
@ds-jhartmann ds-jhartmann dismissed stale reviews from dsmf and ds-psosnowski via c7c4aaf February 2, 2024 09:55
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

ds-psosnowski
ds-psosnowski approved these changes Feb 2, 2024
View reviewed changes
Copy link

@ds-psosnowski ds-psosnowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@ds-jhartmann ds-jhartmann merged commit 2be68b5 into main Feb 2, 2024
@ds-jhartmann ds-jhartmann deleted the feature/#344-integration-tests branch February 2, 2024 10:07
ds-pweick referenced this pull request in ds-pweick/tx-item-relationship-service Jul 3, 2024
@ds-jhartmann
Merge pull request eclipse-tractusx#744 from eclipse-tractusx/chore/u…
6f75cd2 
…pdate-DEPENDENCIES

Update DEPENDENCIES
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ds-psosnowski ds-psosnowski ds-psosnowski approved these changes

@dsmf dsmf dsmf left review comments

@ds-ext-kmassalski ds-ext-kmassalski Awaiting requested review from ds-ext-kmassalski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ds-jhartmann @dsmf @ds-psosnowski