feat(impl):[#244] Show infected supply chain on first tier level + feat(impl):[#246] Show hops number for impacted supply chain #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r supplyChainFirstLevelBpn and hops
…oval of array in impactedSuppliersOnFirstTier
ds-jhartmann
suggested changes
Nov 16, 2023
.../main/java/org/eclipse/tractusx/irs/ess/service/InvestigationJobProcessingEventListener.java
Outdated
Show resolved
Hide resolved
irs-api/src/main/java/org/eclipse/tractusx/irs/ess/service/BpnInvestigationJob.java
Outdated
Show resolved
Hide resolved
…west level of hops, code clean up, added test
…-chain-on-first-tier-level' into feature/TRI-1658-infected-supply-chain-on-first-tier-level
ds-psosnowski
changed the title
|
Kudos, SonarCloud Quality Gate passed! |
|
LGTM but also the code was written by me, so it would be good if @ds-jhartmann could also take a look, |
ds-psosnowski
deleted the
feature/TRI-1658-infected-supply-chain-on-first-tier-level
branch
dsmf
added a commit
that referenced
this pull request
May 14, 2024
dsmf
added a commit
that referenced
this pull request
May 14, 2024
dsmf
added a commit
that referenced
this pull request
May 14, 2024
dsmf
added a commit
that referenced
this pull request
May 14, 2024
dsmf
added a commit
that referenced
this pull request
May 15, 2024
dsmf
added a commit
that referenced
this pull request
May 15, 2024
dsmf
added a commit
that referenced
this pull request
May 15, 2024
dsmf
added a commit
that referenced
this pull request
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Show bpn number when there is supply chain impacted.
I changed approach few times therefore I have only fixed existing tests for that feature. If it solution will be correct, then I will add more tests.
Some code is part of Krzysztof's PR changes, because we overlap in few places.
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: