Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(impl):[TRI-1350] update upload script #395

Merged
merged 1 commit into from
Jul 6, 2023
Merged

feat(impl):[TRI-1350] update upload script #395

merged 1 commit into from
Jul 6, 2023

Conversation

ds-ext-kmassalski
Copy link

No description provided.

ds-jhartmann
ds-jhartmann approved these changes Jul 5, 2023
View reviewed changes
Copy link

@ds-jhartmann ds-jhartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ds-ext-kmassalski ds-ext-kmassalski merged commit 9567d4d into main Jul 6, 2023
@ds-ext-kmassalski ds-ext-kmassalski deleted the feature/TRI-1350-upload-script-adjustments branch July 6, 2023 10:35
dsmf added a commit that referenced this pull request Feb 13, 2024
@dsmf
feat(impl):[#395] Move setup code not used in every test to the indiv…
ad2586a 
…idual tests

reason: only setup code common to all tests should be placed in setup method because otherwise hard to understand and error-prone, because things are setup that aren't used or have to be overwritten somehow
dsmf added a commit that referenced this pull request Feb 16, 2024
@dsmf
feat(imp):[#395] Partial implementation
b9d9dab 
Partial implementation started in context of #214 before story was split up. This commit is just meant to back up the work. It is neither complete nor does it work yet and it still contains compile errors.
dsmf added a commit that referenced this pull request Feb 16, 2024
@dsmf
feat(impl):[#395] Merge master into branch
6ff6dbc
dsmf added a commit that referenced this pull request Feb 16, 2024
@dsmf
feat(impl):[#395] Group tests
e88fd3e
dsmf added a commit that referenced this pull request Feb 16, 2024
@dsmf
feat(impl):[#395] Correct diagrams
e7f0939
dsmf added a commit that referenced this pull request Feb 16, 2024
@dsmf
feat(impl):[#395] Correct diagrams - fix arrow heads
b2d75ab
dsmf added a commit that referenced this pull request Feb 16, 2024
@dsmf
feat(impl):[#395] Add some code comments to diagrams
b9af543
dsmf added a commit that referenced this pull request Feb 16, 2024
@dsmf
feat(impl):[#395] Add some javadoc
e062484
dsmf added a commit that referenced this pull request Feb 16, 2024
@dsmf
feat(impl):[#395] Rename variable, format code
2ab61cc
dsmf added a commit that referenced this pull request Feb 16, 2024
@dsmf
feat(impl):[#395] Add more detailed diagrams
b1e401c
dsmf added a commit that referenced this pull request Feb 16, 2024
@dsmf
feat(impl):[#395] EdcClientException: Add constructor with message an…
4bdd210 
…d cause
dsmf added a commit that referenced this pull request Feb 16, 2024
@dsmf
feat(impl):[#395] Rename local variable
9552b5b
dsmf added a commit that referenced this pull request Feb 16, 2024
@dsmf
feat(impl):[#395] Remove duplicate log
88cd165
dsmf added a commit that referenced this pull request Feb 16, 2024
@dsmf
feat(impl):[#395] Update detail diagrams
a0abc33
dsmf added a commit that referenced this pull request Feb 16, 2024
@dsmf
feat(impl):[#395] Add code comment for special scenario (with TODO fo…
66568e0 
…r clarification)
dsmf added a commit that referenced this pull request Feb 16, 2024
@dsmf
feat(impl):[#395] Add TODO for clarification
70f61d5
dsmf added a commit that referenced this pull request Feb 16, 2024
@dsmf
feat(impl):[#395] Add TODO for clarification
3c61508
dsmf added a commit that referenced this pull request Feb 16, 2024
@dsmf
feat(impl):[#395] Rename local variable
c5f4461
dsmf added a commit that referenced this pull request Feb 16, 2024
@dsmf
feat(impl):[#395] Correct code comments
38e82a3
dsmf added a commit that referenced this pull request Feb 16, 2024
@dsmf
feat(impl):[#395] Remove obsolete todo
06b1738 
this code place is not related to this story
dsmf added a commit that referenced this pull request Feb 16, 2024
@dsmf
feat(impl):[#395] Add Contract Item and Contract Offer to glossary
0373718
dsmf added a commit that referenced this pull request Feb 16, 2024
@dsmf
feat(impl):[#395] Improve glossary
e3857a5
dsmf added a commit that referenced this pull request Feb 16, 2024
@dsmf
feat(impl):[#395] Remove obsolete todo
6f37a0a 
edcRestTemplate is correct here, because we communicate with a DTR via an EDC
dsmf added a commit that referenced this pull request Feb 16, 2024
@dsmf
feat(impl):[#395] Improve comprehensibility
d0d78a9 
- better variable/parameter naming
- split up stream expression into multiple lines
- add helpful code comments to each part
- reference special scenario diagram
dsmf added a commit that referenced this pull request Feb 16, 2024
@dsmf
feat(impl):[#395] Improve glossary
1ece516
dsmf added a commit that referenced this pull request Feb 19, 2024
@dsmf
feat(impl):[#395] Implementation (but tests still need to be adapted)
8298522
dsmf added a commit that referenced this pull request Feb 19, 2024
@dsmf
feat(impl):[#395] Adjust test
0dbb8bb
dsmf added a commit that referenced this pull request Feb 19, 2024
@dsmf
feat(impl):[#395] Fix exception handling
1d27803
dsmf added a commit that referenced this pull request Feb 19, 2024
@dsmf
feat(impl):[#395] Add missing Thread.currentThread().interrupt()
1e6cda4
dsmf added a commit that referenced this pull request Feb 19, 2024
@dsmf
feat(impl):[#395] Fix tests
dbf3066 
And remove test concerning InterruptedException which is no longer relevant in this place.
dsmf added a commit that referenced this pull request Feb 19, 2024
@dsmf
feat(impl):[#395] Improve readability
bb7c3a2
dsmf added a commit that referenced this pull request Feb 19, 2024
@dsmf
feat(impl):[#395] Assert interrupt
97f6b55
dsmf added a commit that referenced this pull request Feb 19, 2024
@dsmf
feat(impl):[#395] Fix test
d9b08f7
dsmf added a commit that referenced this pull request Feb 19, 2024
@dsmf
feat(impl):[#395] Add some wiremock tests
b34ffcd
dsmf added a commit that referenced this pull request Feb 19, 2024
@dsmf
feat(impl):[#395] Cleanup
1cfd3e5
dsmf added a commit that referenced this pull request Feb 19, 2024
@dsmf
feat(impl):[#395] Fix javadoc
cacf29f
dsmf added a commit that referenced this pull request Feb 19, 2024
@dsmf
feat(impl):[#395] Fix long line
090a265
dsmf added a commit that referenced this pull request Feb 19, 2024
@dsmf
feat(impl):[#395] Fix long line
45d069d
dsmf added a commit that referenced this pull request Feb 19, 2024
@dsmf
feat(impl):[#395] Inline short method
3aedb0d
dsmf added a commit that referenced this pull request Feb 19, 2024
@dsmf
feat(impl):[#395] Reduce number of dependencies of EdcSubmodelClientImpl
5725012 
by accessing EndpointDataReferenceStorage via EndpointDataReferenceCacheService only
dsmf added a commit that referenced this pull request Feb 19, 2024
@dsmf
feat(impl):[#395] Inline short method
db6b13a
dsmf added a commit that referenced this pull request Feb 19, 2024
@dsmf
feat(impl):[#395] Cleanup
880a053
dsmf added a commit that referenced this pull request Feb 19, 2024
@dsmf
feat(impl):[#395] Cleanup
9f88251
dsmf added a commit that referenced this pull request Feb 23, 2024
@dsmf
feat(impl):[#395] fix test setup
5fdbd0b
dsmf added a commit that referenced this pull request Feb 23, 2024
@dsmf
feat(impl):[#395] ignore PMD warning
9a435fe 
Already removed dependency to EndpointDataReferenceStorage in previous commits. In order to reduce more imports more refactoring would be required which is far beyond the scope of the current story.
dsmf added a commit that referenced this pull request Feb 23, 2024
@dsmf
feat(impl):[#395] Changelog updated
031e3d4
dsmf added a commit that referenced this pull request Feb 27, 2024
@dsmf
feat(impl):[#395] Remove .cache_ggshield
46eeeef 
this file had been committed accidently
dsmf added a commit that referenced this pull request Feb 27, 2024
@dsmf
feat(impl):[#395] Remove obsolete SuppressWarnings
0646086
dsmf added a commit that referenced this pull request Feb 27, 2024
@dsmf
feat(impl):[#395] Remove obsolete TODOs
fc42751
dsmf added a commit that referenced this pull request Feb 27, 2024
@dsmf
feat(impl):[#395] Update CHANGELOG.md
17cea3d
dsmf added a commit that referenced this pull request Mar 1, 2024
@dsmf
feature(impl):[#395] Corrected / improved test according to review se…
18a6239 
…ssion
@dsmf dsmf mentioned this pull request Mar 1, 2024
Closed
dsmf added a commit that referenced this pull request Mar 1, 2024
@dsmf
feat(impl):[#395] Add GitHub issue number to CHANGELOG
bf8263b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ds-jhartmann ds-jhartmann ds-jhartmann approved these changes

Assignees

@ds-jhartmann ds-jhartmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ds-ext-kmassalski @ds-jhartmann