Merge pull request #326 from catenax-ng/feature/TRI-XXX-code-smells-a…

…djuststments feat(impl):[TRI-XXX] adjustments for smells
catenax-ng · May 12, 2023 · 4a31fde · 4a31fde
2 parents 574a297 + 880e50c
commit 4a31fde
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/irs-api/src/main/java/org/eclipse/tractusx/irs/configuration/TrustedPortConfiguration.java b/irs-api/src/main/java/org/eclipse/tractusx/irs/configuration/TrustedPortConfiguration.java
@@ -58,7 +58,7 @@ public TrustedPortConfiguration(@Value("${server.port:8080}") final String serve
     }
 
     @Bean
-    public WebServerFactoryCustomizer<?> servletContainer() {
+    public WebServerFactoryCustomizer<TomcatServletWebServerFactory> servletContainer() {
 
         final Connector[] additionalConnectors = this.additionalConnector();
 

diff --git a/irs-api/src/main/java/org/eclipse/tractusx/irs/connector/job/PersistentJobStore.java b/irs-api/src/main/java/org/eclipse/tractusx/irs/connector/job/PersistentJobStore.java
@@ -130,9 +130,9 @@ private String toBlobId(final String jobId) {
         return JOB_PREFIX + jobId;
     }
 
-    private Boolean isLastStateSameAsCurrentState(final String jobId, final JobState state) {
+    private boolean isLastStateSameAsCurrentState(final String jobId, final JobState state) {
         final Optional<MultiTransferJob> optJob = get(jobId);
-        return optJob.isPresent() && optJob.get().getJob().getState() == state;
+        return optJob.isPresent() && optJob.get().getJob().getState().equals(state);
     }
 
 }
-Original file line number
+Diff line change
@@ Expand Up @@
         }
         @Bean
-        public WebServerFactoryCustomizer<?> servletContainer() {
+        public WebServerFactoryCustomizer<TomcatServletWebServerFactory> servletContainer() {
             final Connector[] additionalConnectors = this.additionalConnector();
@@ Expand Down @@