Replace provision-oauth2 with data-plane-http-oauth2
#733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
requested review from
DominikPinsel,
florianrusch-zf and
tuncaytunc-zf
tuncaytunc-zf
approved these changes
Feb 9, 2023
florianrusch-zf
approved these changes
Feb 9, 2023
ndr-brt
force-pushed
the
introduce-data-plane-http-oauth2
branch
from
284d935
to
fbfb433
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
replaces
provision-oauth2withdata-plane-http-oauth2why
apparently there can be only 1 provisioner acting on the provider side modifying the content data address, otherwise they'll clash, as we're introducing the additional headers provisioner in #732 , the behavior of handling oauth2 authorization can be done in the data-plane directly with the
data-plane-http-oauth2(that in fact will replace the provision extension in its entirety)NOTE: this needs to be merged before #732, otherwise the business tests there could not pass because the provisioner issue I mentioned.