Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add how to set up cluster info from webpage to our repo #14

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

FaGru3n
Copy link
Contributor

@FaGru3n FaGru3n commented Feb 7, 2024

What would be changed or will be added with this PR?

  • move and adapt format for Markdown files for our internal guides to onboarding tasks
  • last remaining docs/how-to-setup-aks-cluster-via-terraform.md from catena-x ng website
  • remove specific docusaurus content and tranfer it to Markdown format like https://docusaurus.io/docs/next/markdown-features/admonitions

Why do i want to change this?

Validation

@FaGru3n FaGru3n requested a review from a team February 7, 2024 16:11
Copy link
Contributor

@SebastianBezold SebastianBezold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the part about the state should be updated. Rest is fine


Terraform uses [`state`](https://www.terraform.io/language/state) to track status and differences of your real world
resources and your configuration. While being very useful in most situation, we actively decided to NOT manage/save the
terraform state to track our AKS cluster resources. We think, that sharing and storing the state file is too much of an
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely outdated and we should point to the backend configuration in the terraform scripts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

22e0f6c

Did some changes, where directly you want to point to the scripts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where it is defined for the core cluster for example: https://github.com/catenax-ng/cloud-infra/blob/main/01_core_cluster/providers.tf#L2

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But fine for now. At least the outdated parts are removed. We can improve the docs with up-to-date stuff later on

@FaGru3n FaGru3n requested review from SebastianBezold and a team February 9, 2024 10:15
@FaGru3n FaGru3n merged commit 2dde371 into main Feb 16, 2024
@FaGru3n FaGru3n deleted the docs/add-how-to-setup branch February 16, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants