-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multistep #376
Closed
Closed
Multistep #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Kevin-Jonaitis
pushed a commit
to Appdynamics/webpagetest
that referenced
this pull request
Feb 16, 2015
This allows users to set a query parmater "timeout=%d" in runtest.php, where %d is the amount of time to test should be allowed to run for before web page test force quits the test. The results of this test up to this point of timeout will be recorded. If the test times out, the result code for the step that that timeout occured on will be 99996. In order to ensure the security of public-facing WPT instances, a required parameter "EnablePerTestTimeout" must be added to the wptdriver.ini file. Note: In order for multi-step test results to report the correct error message on timeout, you must incldue multistep pull request catchpoint#376 Manual Testing: -Verified new code has no effect when EnablePerTestTimeout is not included in wptdriver.ini file -Verified test times out when timit limit is reached -Verified test does not timeout when time limit is not reached -Verified negative timeout values are disgarded -Verified that partial test results are returned on multi-step test run that timeout -Verified test reports correct error code on multi-step tests with multi-step pull request
Kevin-Jonaitis
pushed a commit
to Appdynamics/webpagetest
that referenced
this pull request
Feb 17, 2015
This allows users to set a query parmater "timeout=%d" in runtest.php, where %d is the amount of time to test should be allowed to run for before web page test force quits the test. The results of this test up to this point of timeout will be recorded. If the test times out, the result code for the step that that timeout occured on will be 99996. In order to ensure the security of public-facing WPT instances, a required parameter "EnablePerTestTimeout" must be added to the wptdriver.ini file. Note: In order for multi-step test results to report the correct error message on timeout, you must incldue multistep pull request catchpoint#376 Manual Testing: -Verified new code has no effect when EnablePerTestTimeout is not included in wptdriver.ini file -Verified test times out when timit limit is reached -Verified test does not timeout when time limit is not reached -Verified negative timeout values are disgarded -Verified that partial test results are returned on multi-step test run that timeout -Verified test reports correct error code on multi-step tests with multi-step pull request
Kevin-Jonaitis
pushed a commit
to Appdynamics/webpagetest
that referenced
this pull request
Feb 18, 2015
This allows users to set a query parmater "timeout=%d" in runtest.php, where %d is the amount of time to test should be allowed to run for before web page test force quits the test. The results of this test up to this point of timeout will be recorded. If the test times out, the result code for the step that that timeout occured on will be 99996. In order to ensure the security of public-facing WPT instances, a required parameter "EnablePerTestTimeout" must be added to the wptdriver.ini file. Note: In order for multi-step test results to report the correct error message on timeout, you must incldue multistep pull request catchpoint#376 Manual Testing: -Verified new code has no effect when EnablePerTestTimeout is not included in wptdriver.ini file -Verified test times out when timit limit is reached -Verified test does not timeout when time limit is not reached -Verified negative timeout values are disgarded -Verified that partial test results are returned on multi-step test run that timeout -Verified test reports correct error code on multi-step tests with multi-step pull request
Kevin-Jonaitis
pushed a commit
to Appdynamics/webpagetest
that referenced
this pull request
Feb 28, 2015
This allows users to set a query parmater "timeout=%d" in runtest.php, where %d is the amount of time to test should be allowed to run for before web page test force quits the test. The results of this test up to this point of timeout will be recorded. If the test times out, the result code for the step that that timeout occured on will be 99996. In order to ensure the security of public-facing WPT instances, a required parameter "EnablePerTestTimeout" must be added to the wptdriver.ini file. Note: In order for multi-step test results to report the correct error message on timeout, you must incldue multistep pull request catchpoint#376 Manual Testing: -Verified new code has no effect when EnablePerTestTimeout is not included in wptdriver.ini file -Verified test times out when timit limit is reached -Verified test does not timeout when time limit is not reached -Verified negative timeout values are disgarded -Verified that partial test results are returned on multi-step test run that timeout -Verified test reports correct error code on multi-step tests with multi-step pull request
Kevin-Jonaitis
pushed a commit
to Appdynamics/webpagetest
that referenced
this pull request
Mar 3, 2015
This allows users to set a query parmater "timeout=%d" in runtest.php, where %d is the amount of time to test should be allowed to run for before web page test force quits the test. The results of this test up to this point of timeout will be recorded. If the test times out, the result code for the step that that timeout occured on will be 99996. Note: In order for multi-step test results to report the correct error message on timeout, you must incldue multistep pull request catchpoint#376 Manual Testing: -Verified new code has no effect when EnablePerTestTimeout is not included in wptdriver.ini file -Verified test times out when timit limit is reached -Verified test does not timeout when time limit is not reached -Verified negative timeout values are disgarded -Verified that partial test results are returned on multi-step test run that timeout -Verified test reports correct error code on multi-step tests with multi-step pull request
Kevin-Jonaitis
pushed a commit
to Appdynamics/webpagetest
that referenced
this pull request
Mar 6, 2015
This allows users to set a query parmater "timeout=%d" in runtest.php, where %d is the amount of time to test should be allowed to run for before web page test force quits the test. The results of this test up to this point of timeout will be recorded. If the test times out, the result code for the step that that timeout occured on will be 99996. Note: In order for multi-step test results to report the correct error message on timeout, you must incldue multistep pull request catchpoint#376 Manual Testing: -Verified new code has no effect when EnablePerTestTimeout is not included in wptdriver.ini file -Verified test times out when timit limit is reached -Verified test does not timeout when time limit is not reached -Verified negative timeout values are disgarded -Verified that partial test results are returned on multi-step test run
Kevin-Jonaitis
pushed a commit
to Appdynamics/webpagetest
that referenced
this pull request
Mar 12, 2015
This allows users to set a query parmater "timeout=%d" in runtest.php, where %d is the amount of time to test should be allowed to run for before web page test force quits the test. The results of this test up to this point of timeout will be recorded. If the test times out, the result code for the step that that timeout occured on will be 99996. Note: In order for multi-step test results to report the correct error message on timeout, you must incldue multistep pull request catchpoint#376 Manual Testing: -Verified new code has no effect when EnablePerTestTimeout is not included in wptdriver.ini file -Verified test times out when timit limit is reached -Verified test does not timeout when time limit is not reached -Verified negative timeout values are disgarded -Verified that partial test results are returned on multi-step test run Conflicts: www/runtest.php
Kevin-Jonaitis
pushed a commit
to Appdynamics/webpagetest
that referenced
this pull request
Mar 12, 2015
This allows users to set a query parmater "timeout=%d" in runtest.php, where %d is the amount of time to test should be allowed to run for before web page test force quits the test. The results of this test up to this point of timeout will be recorded. If the test times out, the result code for the step that that timeout occured on will be 99996. Note: In order for multi-step test results to report the correct error message on timeout, you must incldue multistep pull request catchpoint#376 Manual Testing: -Verified new code has no effect when EnablePerTestTimeout is not included in wptdriver.ini file -Verified test times out when timit limit is reached -Verified test does not timeout when time limit is not reached -Verified negative timeout values are disgarded -Verified that partial test results are returned on multi-step test run Conflicts: www/runtest.php
…istep-format, create multistep-waterfalls, multistep detail results, multistep response bodies, accordeon waterfalls, modify visual progress by cropping through PNG, XML-results in multistep-format, accepts results in multistep-format from desktop-agent, nodejs-android-agent and iOS-agent
…a waterfall-view, which could take some time...
…ormat for enabling more compatibility to a singlestep-server
…ility to singlestep-agents
…ll jump to the waterfall and open it
This reverts commit 6a45c12.
This can be closed as it's going to be replaced step by step (see #618). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multistep adaptions to windows agent (wptdriver) and PHP server. It's based on commit 8df57bb. Should be the same functionality demonstrated on velocity 2014 europe in Barcelona by Uwe Bessle and Nils Kuhn, updated to newer WebPagetest server and agent code.