Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multistep #376

Closed
wants to merge 79 commits into from
Closed

Multistep #376

wants to merge 79 commits into from

Conversation

iteratec-hh
Copy link

Multistep adaptions to windows agent (wptdriver) and PHP server. It's based on commit 8df57bb. Should be the same functionality demonstrated on velocity 2014 europe in Barcelona by Uwe Bessle and Nils Kuhn, updated to newer WebPagetest server and agent code.

@pmeenan pmeenan mentioned this pull request Jan 7, 2015
Kevin-Jonaitis pushed a commit to Appdynamics/webpagetest that referenced this pull request Feb 16, 2015
This allows users to set a query parmater "timeout=%d" in runtest.php,
where %d is the amount of time to test should be allowed to run for
before web page test force quits the test.

The results of this test up to this point of timeout will be recorded.
If the test times out, the result code for the step that that timeout
occured on will be 99996.

In order to ensure the security of public-facing WPT instances, a required
parameter "EnablePerTestTimeout" must be added to the wptdriver.ini file.

Note: In order for multi-step test results to report the correct error
message on timeout, you must incldue multistep pull request catchpoint#376

Manual Testing:
-Verified new code has no effect when EnablePerTestTimeout is not included
in wptdriver.ini file
-Verified test times out when timit limit is reached
-Verified test does not timeout when time limit is not reached
-Verified negative timeout values are disgarded
-Verified that partial test results are returned on multi-step test run
that timeout
-Verified test reports correct error code on multi-step tests with
multi-step pull request
Kevin-Jonaitis pushed a commit to Appdynamics/webpagetest that referenced this pull request Feb 17, 2015
This allows users to set a query parmater "timeout=%d" in runtest.php,
where %d is the amount of time to test should be allowed to run for
before web page test force quits the test.

The results of this test up to this point of timeout will be recorded.
If the test times out, the result code for the step that that timeout
occured on will be 99996.

In order to ensure the security of public-facing WPT instances, a required
parameter "EnablePerTestTimeout" must be added to the wptdriver.ini file.

Note: In order for multi-step test results to report the correct error
message on timeout, you must incldue multistep pull request catchpoint#376

Manual Testing:
-Verified new code has no effect when EnablePerTestTimeout is not included
in wptdriver.ini file
-Verified test times out when timit limit is reached
-Verified test does not timeout when time limit is not reached
-Verified negative timeout values are disgarded
-Verified that partial test results are returned on multi-step test run
that timeout
-Verified test reports correct error code on multi-step tests with
multi-step pull request
Kevin-Jonaitis pushed a commit to Appdynamics/webpagetest that referenced this pull request Feb 18, 2015
This allows users to set a query parmater "timeout=%d" in runtest.php,
where %d is the amount of time to test should be allowed to run for
before web page test force quits the test.

The results of this test up to this point of timeout will be recorded.
If the test times out, the result code for the step that that timeout
occured on will be 99996.

In order to ensure the security of public-facing WPT instances, a required
parameter "EnablePerTestTimeout" must be added to the wptdriver.ini file.

Note: In order for multi-step test results to report the correct error
message on timeout, you must incldue multistep pull request catchpoint#376

Manual Testing:
-Verified new code has no effect when EnablePerTestTimeout is not included
in wptdriver.ini file
-Verified test times out when timit limit is reached
-Verified test does not timeout when time limit is not reached
-Verified negative timeout values are disgarded
-Verified that partial test results are returned on multi-step test run
that timeout
-Verified test reports correct error code on multi-step tests with
multi-step pull request
Kevin-Jonaitis pushed a commit to Appdynamics/webpagetest that referenced this pull request Feb 28, 2015
This allows users to set a query parmater "timeout=%d" in runtest.php,
where %d is the amount of time to test should be allowed to run for
before web page test force quits the test.

The results of this test up to this point of timeout will be recorded.
If the test times out, the result code for the step that that timeout
occured on will be 99996.

In order to ensure the security of public-facing WPT instances, a required
parameter "EnablePerTestTimeout" must be added to the wptdriver.ini file.

Note: In order for multi-step test results to report the correct error
message on timeout, you must incldue multistep pull request catchpoint#376

Manual Testing:
-Verified new code has no effect when EnablePerTestTimeout is not included
in wptdriver.ini file
-Verified test times out when timit limit is reached
-Verified test does not timeout when time limit is not reached
-Verified negative timeout values are disgarded
-Verified that partial test results are returned on multi-step test run
that timeout
-Verified test reports correct error code on multi-step tests with
multi-step pull request
Kevin-Jonaitis pushed a commit to Appdynamics/webpagetest that referenced this pull request Mar 3, 2015
This allows users to set a query parmater "timeout=%d" in runtest.php,
where %d is the amount of time to test should be allowed to run for
before web page test force quits the test.

The results of this test up to this point of timeout will be recorded.
If the test times out, the result code for the step that that timeout
occured on will be 99996.

Note: In order for multi-step test results to report the correct error
message on timeout, you must incldue multistep pull request catchpoint#376

Manual Testing:
-Verified new code has no effect when EnablePerTestTimeout is not included
in wptdriver.ini file
-Verified test times out when timit limit is reached
-Verified test does not timeout when time limit is not reached
-Verified negative timeout values are disgarded
-Verified that partial test results are returned on multi-step test run
that timeout
-Verified test reports correct error code on multi-step tests with
multi-step pull request
Kevin-Jonaitis pushed a commit to Appdynamics/webpagetest that referenced this pull request Mar 6, 2015
This allows users to set a query parmater "timeout=%d" in runtest.php,
where %d is the amount of time to test should be allowed to run for
before web page test force quits the test.

The results of this test up to this point of timeout will be recorded.
If the test times out, the result code for the step that that timeout
occured on will be 99996.

Note: In order for multi-step test results to report the correct error
message on timeout, you must incldue multistep pull request catchpoint#376

Manual Testing:
-Verified new code has no effect when EnablePerTestTimeout is not included
in wptdriver.ini file
-Verified test times out when timit limit is reached
-Verified test does not timeout when time limit is not reached
-Verified negative timeout values are disgarded
-Verified that partial test results are returned on multi-step test run
Kevin-Jonaitis pushed a commit to Appdynamics/webpagetest that referenced this pull request Mar 12, 2015
This allows users to set a query parmater "timeout=%d" in runtest.php,
where %d is the amount of time to test should be allowed to run for
before web page test force quits the test.

The results of this test up to this point of timeout will be recorded.
If the test times out, the result code for the step that that timeout
occured on will be 99996.

Note: In order for multi-step test results to report the correct error
message on timeout, you must incldue multistep pull request catchpoint#376

Manual Testing:
-Verified new code has no effect when EnablePerTestTimeout is not included
in wptdriver.ini file
-Verified test times out when timit limit is reached
-Verified test does not timeout when time limit is not reached
-Verified negative timeout values are disgarded
-Verified that partial test results are returned on multi-step test run

Conflicts:
	www/runtest.php
Kevin-Jonaitis pushed a commit to Appdynamics/webpagetest that referenced this pull request Mar 12, 2015
This allows users to set a query parmater "timeout=%d" in runtest.php,
where %d is the amount of time to test should be allowed to run for
before web page test force quits the test.

The results of this test up to this point of timeout will be recorded.
If the test times out, the result code for the step that that timeout
occured on will be 99996.

Note: In order for multi-step test results to report the correct error
message on timeout, you must incldue multistep pull request catchpoint#376

Manual Testing:
-Verified new code has no effect when EnablePerTestTimeout is not included
in wptdriver.ini file
-Verified test times out when timit limit is reached
-Verified test does not timeout when time limit is not reached
-Verified negative timeout values are disgarded
-Verified that partial test results are returned on multi-step test run

Conflicts:
	www/runtest.php
@BirgerK BirgerK deleted the multistep branch September 18, 2015 10:37
BirgerK added 20 commits September 18, 2015 14:30
…istep-format, create multistep-waterfalls, multistep detail results, multistep response bodies, accordeon waterfalls, modify visual progress by cropping through PNG, XML-results in multistep-format, accepts results in multistep-format from desktop-agent, nodejs-android-agent and iOS-agent
…a waterfall-view, which could take some time...
…ormat for enabling more compatibility to a singlestep-server
BirgerK and others added 27 commits October 16, 2015 21:23
…. I pulled the original-file from github again
Also fixed some merge-bugs by copying again original-file from github
…, every measuring is a multistep-measurement
@sburnicki
Copy link
Contributor

This can be closed as it's going to be replaced step by step (see #618).

@pmeenan pmeenan closed this May 25, 2016
jefflembeck added a commit that referenced this pull request Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants