Update catch_suppress_warnings.h

[YarikTH]

fixed "pragma GCC diagnostic push" after "pragma GCC diagnostic ignored"

Description

I found unusual gcc warnings pattern in catch_suppress_warnings.h that obviosly a bug added by someone who doesn't familar with diagnostic push-ignored-pop pattern.

#    pragma GCC diagnostic ignored "-Wparentheses"
#    pragma GCC diagnostic push
#    pragma GCC diagnostic ignored "-Wunused-variable"
#    pragma GCC diagnostic ignored "-Wpadded"

So I just moved "push" before first "ignored"

[codecov]

Codecov Report

Merging #1508 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1508   +/-   ##
=======================================
  Coverage   80.53%   80.53%           
=======================================
  Files         121      121           
  Lines        3436     3436           
=======================================
  Hits         2767     2767           
  Misses        669      669

[codecov]

Codecov Report

Merging #1508 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1508   +/-   ##
=======================================
  Coverage   80.53%   80.53%           
=======================================
  Files         121      121           
  Lines        3436     3436           
=======================================
  Hits         2767     2767           
  Misses        669      669

[YarikTH]

Locally suppress hidden warnings on Class and Compile tests that appeared on gcc-4.8 gcc-4.9 and gcc-5.0

[YarikTH]

I found #674 and understand comment above suppression

// GCC likes to warn on REQUIREs, and we cannot suppress them
// locally because g++'s support for _Pragma is lacking in older,
// still supported, versions
#    pragma GCC diagnostic ignored "-Wparentheses"
#    pragma GCC diagnostic push

So I close request. But it would be better to mark this more obviously. Because now it's unclear from comment before. e.g.:

// GCC likes to warn on REQUIREs, and we cannot suppress them
// locally because g++'s support for _Pragma is lacking in older,
// still supported, versions
#    pragma GCC diagnostic ignored "-Wparentheses" //< Don't move under push/pop. See #674
#    pragma GCC diagnostic push

or

// GCC likes to warn on REQUIREs, and we cannot suppress them
// locally because g++'s support for _Pragma is lacking in older,
// still supported, versions
// [
#    pragma GCC diagnostic ignored "-Wparentheses"
// ]
#    pragma GCC diagnostic push

[horenmar]

Ok, I modified the comment somewhat to be clearer.