Use prop-types package instead of deprecated React.PropTypes import. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves warning: "Accessing PropTypes via the main React package is deprecated. ..." Also updated Radium to v0.19.1 to capture their prop-types package fix as well.
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a run-time warning when rendering the Timepicker widget:
I've also updated Radium to v0.19.1 to capture their prop-types package fix as well. Relevant Radium PR: FormidableLabs/radium#898. This change was first introduced into Radium v0.18.3 though they later reverted it and did a major version bump to 0.19.x instead for it.
Specs are passing, and all examples on the demo page seems to work and look the same as before during a manual test.
Resolves issue: oatycreates/scheduler-for-toggl#2
Thanks for creating this widget! I've been looking around for a good Android clock-style time picker for a while now. 🙂