-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SortedRecordingConverter
for solving unit electrode provenance in sorted data
#1132
Draft
h-mayorquin
wants to merge
18
commits into
main
Choose a base branch
from
add_sorted_recording
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-mayorquin
changed the title
SortedRecordingConverter for solving unit electrode provenance
Nov 7, 2024
SortedRecordingConverter
for solving unit electrode provenance
h-mayorquin
changed the title
Nov 7, 2024
SortedRecordingConverter
for solving unit electrode provenanceSortedRecordingConverter
for solving unit electrode provenance in sorted data
Base automatically changed from
add_electrode_disambiguation_in_sorting_interfaces
to
main
November 15, 2024 18:24
2 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1132 +/- ##
==========================================
- Coverage 90.69% 90.64% -0.05%
==========================================
Files 129 130 +1
Lines 8189 8329 +140
==========================================
+ Hits 7427 7550 +123
- Misses 762 779 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has #1124 as a base and should be done after that.
This converter can be used to write sorted data and keep the correct electrode provenance of the units (display electrodes in the units table). The converted takes care of handling the correct map between units and electrodes which is important for multiple recording/probes such as the one discussed in #1112.
Also related to this:
#961