Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SortedRecordingConverter for solving unit electrode provenance in sorted data #1132

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

h-mayorquin
Copy link
Collaborator

This has #1124 as a base and should be done after that.

This converter can be used to write sorted data and keep the correct electrode provenance of the units (display electrodes in the units table). The converted takes care of handling the correct map between units and electrodes which is important for multiple recording/probes such as the one discussed in #1112.

Also related to this:
#961

@h-mayorquin h-mayorquin self-assigned this Nov 7, 2024
@h-mayorquin h-mayorquin changed the title SortedRecordingConverter for solving unit electrode provenance SortedRecordingConverter for solving unit electrode provenance Nov 7, 2024
@h-mayorquin h-mayorquin changed the title SortedRecordingConverter for solving unit electrode provenance SortedRecordingConverter for solving unit electrode provenance in sorted data Nov 7, 2024
Base automatically changed from add_electrode_disambiguation_in_sorting_interfaces to main November 15, 2024 18:24
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 70.83333% with 14 lines in your changes missing coverage. Please review.

Project coverage is 90.64%. Comparing base (96dfdff) to head (edaaf40).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...datainterfaces/ecephys/sortedrecordinginterface.py 65.85% 14 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1132      +/-   ##
==========================================
- Coverage   90.69%   90.64%   -0.05%     
==========================================
  Files         129      130       +1     
  Lines        8189     8329     +140     
==========================================
+ Hits         7427     7550     +123     
- Misses        762      779      +17     
Flag Coverage Δ
unittests 90.64% <70.83%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/neuroconv/converters/__init__.py 100.00% <100.00%> (ø)
...erfaces/ecephys/baserecordingextractorinterface.py 94.00% <100.00%> (+0.18%) ⬆️
...nterfaces/ecephys/basesortingextractorinterface.py 80.76% <100.00%> (+0.57%) ⬆️
src/neuroconv/nwbconverter.py 94.96% <ø> (ø)
...datainterfaces/ecephys/sortedrecordinginterface.py 65.85% <65.85%> (ø)

... and 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant