Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add always_write_timestamps conversion option to imaging interfaces #1125

Merged
merged 7 commits into from
Nov 11, 2024

Conversation

h-mayorquin
Copy link
Collaborator

This was discussed in the context of the Cai project with @alessandratrapani

Similar to this one for the ecephys side:
#1091

@h-mayorquin h-mayorquin self-assigned this Nov 5, 2024
@h-mayorquin h-mayorquin changed the title Add always_write_timestamps to imaging Add always_write_timestamps conversion option to imaging interfaces Nov 6, 2024
@h-mayorquin h-mayorquin marked this pull request as ready for review November 6, 2024 20:14
@h-mayorquin
Copy link
Collaborator Author

As we are updating roiextractors here this should close #1108

Copy link
Contributor

@alessandratrapani alessandratrapani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Heberto! This looks good to me!

@h-mayorquin h-mayorquin enabled auto-merge (squash) November 11, 2024 16:38
@h-mayorquin h-mayorquin merged commit 6960872 into main Nov 11, 2024
39 of 40 checks passed
@h-mayorquin h-mayorquin deleted the add_write_timestamps_to_imaging branch November 11, 2024 20:17
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.60%. Comparing base (cbf68d4) to head (61f2c4b).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1125      +/-   ##
==========================================
+ Coverage   90.55%   90.60%   +0.04%     
==========================================
  Files         129      129              
  Lines        8187     8174      -13     
==========================================
- Hits         7414     7406       -8     
+ Misses        773      768       -5     
Flag Coverage Δ
unittests 90.60% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...atainterfaces/behavior/video/videodatainterface.py 93.54% <ø> (-0.09%) ⬇️
...ainterfaces/ophys/baseimagingextractorinterface.py 98.18% <ø> (+3.02%) ⬆️
src/neuroconv/tools/roiextractors/roiextractors.py 82.41% <100.00%> (+0.18%) ⬆️
src/neuroconv/tools/testing/mock_interfaces.py 100.00% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants