-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add skip channels to EDF interface #1110
Conversation
extractor_kwargs = source_data.copy() | ||
extractor_kwargs.pop("channels_to_skip") | ||
extractor_kwargs["all_annotations"] = True | ||
extractor_kwargs["use_names_as_ids"] = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bendichter
This is necessary to display meaningful names that the user can suppress with the newly added parameter. Otherwise, the channel ids are "1", "2", "3", etc.
This is technically a breaking change because we are changing the way we add the data to the NWBFile but I also consider this an improvement:
@h-mayorquin this looks good! Can you confirm that this is able to read and convert the sample EDF file? |
Yes, can't attach the stub here but I will send it on slack. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1110 +/- ##
==========================================
+ Coverage 90.44% 90.57% +0.13%
==========================================
Files 129 129
Lines 8055 8173 +118
==========================================
+ Hits 7285 7403 +118
Misses 770 770
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Related to #1106
This adds the user to the possibility of skipping non-neural channels on the EDF interface.
Some relevant comments: