Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DANDI upload to YAML spec #1089

Merged
merged 27 commits into from
Dec 9, 2024
Merged

Add DANDI upload to YAML spec #1089

merged 27 commits into from
Dec 9, 2024

Conversation

CodyCBakerPhD
Copy link
Member

A general feature, but most necessary for the NeuroConv cloud stuff

@CodyCBakerPhD CodyCBakerPhD self-assigned this Sep 17, 2024
@CodyCBakerPhD
Copy link
Member Author

TODO: splinter test into live services

@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review September 28, 2024 01:36
@CodyCBakerPhD
Copy link
Member Author

@h-mayorquin Tests passing now!

Pretty simply minimal modification all in all

@h-mayorquin h-mayorquin merged commit 4b3172c into main Dec 9, 2024
40 checks passed
@h-mayorquin h-mayorquin deleted the dandi_upload_yaml branch December 9, 2024 17:06
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 52.94118% with 8 lines in your changes missing coverage. Please review.

Project coverage is 90.87%. Comparing base (96dfdff) to head (9cfd2a8).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...on_specification/_yaml_conversion_specification.py 52.94% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1089      +/-   ##
==========================================
+ Coverage   90.69%   90.87%   +0.17%     
==========================================
  Files         129      129              
  Lines        8189     8206      +17     
==========================================
+ Hits         7427     7457      +30     
+ Misses        762      749      -13     
Flag Coverage Δ
unittests 90.87% <52.94%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...on_specification/_yaml_conversion_specification.py 88.88% <52.94%> (-8.38%) ⬇️

... and 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants