Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github CI only run doctests when tests are not run #1077

Merged
merged 7 commits into from
Sep 13, 2024

Conversation

h-mayorquin
Copy link
Collaborator

@h-mayorquin h-mayorquin commented Sep 11, 2024

The full tests also run the doctests so the "doctest only" workflow should only run when the normal tests are not running.

@h-mayorquin h-mayorquin self-assigned this Sep 11, 2024
Copy link
Member

@pauladkisson pauladkisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pauladkisson pauladkisson enabled auto-merge (squash) September 12, 2024 17:33
@pauladkisson pauladkisson merged commit f7e9c4e into main Sep 13, 2024
35 checks passed
@pauladkisson pauladkisson deleted the test_delaying_changelog_test branch September 13, 2024 00:33
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.38%. Comparing base (81a022d) to head (47df590).
Report is 66 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1077      +/-   ##
==========================================
+ Coverage   90.32%   90.38%   +0.06%     
==========================================
  Files         129      129              
  Lines        7996     8005       +9     
==========================================
+ Hits         7222     7235      +13     
+ Misses        774      770       -4     
Flag Coverage Δ
unittests 90.38% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants