Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using in-house GenericDataChunkIterator #1068

Merged
merged 5 commits into from
Sep 17, 2024
Merged

Conversation

h-mayorquin
Copy link
Collaborator

As in the title.

We thought we were testing this for a while but turns out we did not.

@h-mayorquin h-mayorquin self-assigned this Sep 10, 2024
@CodyCBakerPhD
Copy link
Member

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.36%. Comparing base (81a022d) to head (198a6ec).
Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1068      +/-   ##
==========================================
+ Coverage   90.32%   90.36%   +0.03%     
==========================================
  Files         129      129              
  Lines        7996     7998       +2     
==========================================
+ Hits         7222     7227       +5     
+ Misses        774      771       -3     
Flag Coverage Δ
unittests 90.36% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...oconv/datainterfaces/behavior/video/video_utils.py 97.14% <100.00%> (ø)
..._helpers/_configuration_models/_base_dataset_io.py 95.76% <100.00%> (-0.04%) ⬇️
...roiextractors/imagingextractordatachunkiterator.py 100.00% <100.00%> (ø)
...erface/spikeinterfacerecordingdatachunkiterator.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@h-mayorquin h-mayorquin marked this pull request as ready for review September 17, 2024 23:19
@h-mayorquin h-mayorquin merged commit 9dc05c6 into main Sep 17, 2024
2 of 11 checks passed
@h-mayorquin h-mayorquin deleted the enable_local_iterator branch September 17, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants