Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MockSegmentationInterface #1067

Merged
merged 14 commits into from
Sep 13, 2024
Merged

Conversation

h-mayorquin
Copy link
Collaborator

As in the title.

@h-mayorquin h-mayorquin self-assigned this Sep 10, 2024
@h-mayorquin h-mayorquin marked this pull request as ready for review September 10, 2024 02:28
@@ -162,24 +165,52 @@ class MockImagingInterface(BaseImagingExtractorInterface):
A mock imaging interface for testing purposes.
"""

ExtractorModuleName = "roiextractors.testing"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do these changes have to do with a MockSegmentationInterface?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is related to make the MockImagingInterface to work with some of the magic in the tests mixings. I can make this changes in a different PR if that is what you are asking.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think this is a good idea anyways. Check:

#1076

src/neuroconv/tools/testing/mock_interfaces.py Outdated Show resolved Hide resolved
src/neuroconv/tools/testing/mock_interfaces.py Outdated Show resolved Hide resolved
The sampling frequency of the mock imaging data in Hz, by default 30.
dtype : str, optional
The data type of the generated imaging data (e.g., 'uint16'), by default 'uint16'.
verbose : bool, optional
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of these verbose's is redundant.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@h-mayorquin h-mayorquin changed the base branch from main to make_get_extractor_work_with_mock_imaging September 11, 2024 17:22
@h-mayorquin h-mayorquin changed the base branch from make_get_extractor_work_with_mock_imaging to main September 11, 2024 17:23
@h-mayorquin
Copy link
Collaborator Author

OK, did the changes, #1076 should come before.

Copy link
Contributor

@weiglszonja weiglszonja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-mayorquin h-mayorquin enabled auto-merge (squash) September 12, 2024 17:53
@h-mayorquin h-mayorquin merged commit ad1e2a1 into main Sep 13, 2024
35 checks passed
@h-mayorquin h-mayorquin deleted the add_segmentation_dummy_interface branch September 13, 2024 20:49
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.42%. Comparing base (96c8ed4) to head (c2b841f).
Report is 52 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1067      +/-   ##
==========================================
+ Coverage   90.40%   90.42%   +0.01%     
==========================================
  Files         129      129              
  Lines        8029     8041      +12     
==========================================
+ Hits         7259     7271      +12     
  Misses        770      770              
Flag Coverage Δ
unittests 90.42% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rfaces/ophys/basesegmentationextractorinterface.py 100.00% <100.00%> (ø)
src/neuroconv/tools/testing/mock_interfaces.py 100.00% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants