-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MockSegmentationInterface
#1067
Conversation
@@ -162,24 +165,52 @@ class MockImagingInterface(BaseImagingExtractorInterface): | |||
A mock imaging interface for testing purposes. | |||
""" | |||
|
|||
ExtractorModuleName = "roiextractors.testing" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do these changes have to do with a MockSegmentationInterface?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is related to make the MockImagingInterface to work with some of the magic in the tests mixings. I can make this changes in a different PR if that is what you are asking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think this is a good idea anyways. Check:
The sampling frequency of the mock imaging data in Hz, by default 30. | ||
dtype : str, optional | ||
The data type of the generated imaging data (e.g., 'uint16'), by default 'uint16'. | ||
verbose : bool, optional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of these verbose's is redundant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Co-authored-by: Paul Adkisson <[email protected]>
Co-authored-by: Paul Adkisson <[email protected]>
OK, did the changes, #1076 should come before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1067 +/- ##
==========================================
+ Coverage 90.40% 90.42% +0.01%
==========================================
Files 129 129
Lines 8029 8041 +12
==========================================
+ Hits 7259 7271 +12
Misses 770 770
Flags with carried forward coverage won't be shown. Click here to find out more.
|
As in the title.