Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable testing arm64 Mac architecture in the CI. #1061

Merged
merged 19 commits into from
Sep 16, 2024

Conversation

h-mayorquin
Copy link
Collaborator

As in the title. Shoul fix #1054

Let's get the ball rolling on this.

@h-mayorquin h-mayorquin self-assigned this Sep 6, 2024
@h-mayorquin
Copy link
Collaborator Author

OK, this is working, we need somehow to skip the doc test for DeepLabCut with M1s and python=3.9. On the other hand, if we follow the numpy convention we should stop supporting python 3.9 now so maybe we don't need to do that.

@pauladkisson
Copy link
Member

But this also has the support for the intel mac which I think was only discontinued from pros two years ago or something? To be honest, I would prefer to test only on latest mac, the CI is already super bloated on my view but I think there might be a case here for the two.

How do you feel about it?

I am still using an intel mac, so I would like the tests to include it. Plus, I think they're still relatively common. I agree that the CI is a bit bloated and takes too long to pick up new jobs, but I don't think this is the place to make cuts.

@h-mayorquin
Copy link
Collaborator Author

h-mayorquin commented Sep 13, 2024

but I don't think this is the place to make cuts.

This make sense.

Let's brainstorm how to improve the CI at some point.

@h-mayorquin h-mayorquin enabled auto-merge (squash) September 16, 2024 16:02
@h-mayorquin h-mayorquin merged commit 4c7e027 into main Sep 16, 2024
35 checks passed
@h-mayorquin h-mayorquin deleted the enable_support_for_latest_mac_architecture branch September 16, 2024 18:10
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.43%. Comparing base (ad9f25d) to head (e4461c2).
Report is 50 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1061   +/-   ##
=======================================
  Coverage   90.43%   90.43%           
=======================================
  Files         129      129           
  Lines        8052     8053    +1     
=======================================
+ Hits         7282     7283    +1     
  Misses        770      770           
Flag Coverage Δ
unittests 90.43% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...v/datainterfaces/behavior/deeplabcut/_dlc_utils.py 55.42% <100.00%> (+0.27%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add arm64 Mac testing
3 participants