-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable testing arm64 Mac architecture in the CI. #1061
Enable testing arm64 Mac architecture in the CI. #1061
Conversation
OK, this is working, we need somehow to skip the doc test for DeepLabCut with M1s and python=3.9. On the other hand, if we follow the numpy convention we should stop supporting python 3.9 now so maybe we don't need to do that. |
…latest_mac_architecture' into enable_support_for_latest_mac_architecture
I am still using an intel mac, so I would like the tests to include it. Plus, I think they're still relatively common. I agree that the CI is a bit bloated and takes too long to pick up new jobs, but I don't think this is the place to make cuts. |
This make sense. Let's brainstorm how to improve the CI at some point. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1061 +/- ##
=======================================
Coverage 90.43% 90.43%
=======================================
Files 129 129
Lines 8052 8053 +1
=======================================
+ Hits 7282 7283 +1
Misses 770 770
Flags with carried forward coverage won't be shown. Click here to find out more.
|
As in the title. Shoul fix #1054
Let's get the ball rolling on this.