Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate warning about setting timestamps in the ecephys stream #1060

Merged
merged 2 commits into from
Sep 7, 2024

Conversation

h-mayorquin
Copy link
Collaborator

This is something that @CodyCBakerPhD requested from me a while ago and I forgot to do.

That warning is meant for people who will use this in preprocessing (and I think it should be triggered in a different place) but this should suppress this uninformative warning in our use case.

@h-mayorquin h-mayorquin self-assigned this Sep 6, 2024
@h-mayorquin h-mayorquin marked this pull request as ready for review September 7, 2024 03:22
@h-mayorquin h-mayorquin enabled auto-merge (squash) September 7, 2024 03:59
@h-mayorquin h-mayorquin merged commit 81a022d into main Sep 7, 2024
34 of 35 checks passed
@h-mayorquin h-mayorquin deleted the eliminate_warnings_about_settings_timestamps branch September 7, 2024 21:37
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.32%. Comparing base (1498a50) to head (a24fe04).
Report is 61 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1060   +/-   ##
=======================================
  Coverage   90.32%   90.32%           
=======================================
  Files         129      129           
  Lines        7996     7996           
=======================================
  Hits         7222     7222           
  Misses        774      774           
Flag Coverage Δ
unittests 90.32% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...erfaces/ecephys/baserecordingextractorinterface.py 92.78% <100.00%> (ø)
...nterfaces/ecephys/basesortingextractorinterface.py 79.79% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants