Fix bug in Intan interface where extra device is written #1059
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the metadata in metadata["Ecephys"]["ElectrodeGroups"] contains a contains a reference to a device here:
neuroconv/src/neuroconv/datainterfaces/ecephys/baserecordingextractorinterface.py
Lines 92 to 95 in 675ec48
When the code hits these lines another device is created:
neuroconv/src/neuroconv/tools/spikeinterface/spikeinterface.py
Lines 175 to 184 in 675ec48
This resulted in me getting an nwbfile with two devices Intan and the generic one that the default metadata included.
This PR fixes this, I added a test and took the opportunity to move the Intan tests to the new format.
Plus, I made a small improvement to the metadata where the specific controller that was used is indicated as a Device Description:
https://intantech.com/RHD_system.html
https://intantech.com/RHS_system.html
Finally, I also removed a bunch of deprecations whose time has come and logic that was only valid when python-neo version requirement was lower.