Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pydantic IVb] Pydantic validation on arrays #1055

Merged
merged 19 commits into from
Sep 6, 2024
Merged

Conversation

CodyCBakerPhD
Copy link
Member

Follow up to add remaining validation calls for interfaces using arrays

@CodyCBakerPhD CodyCBakerPhD self-assigned this Sep 4, 2024
@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review September 5, 2024 18:37
@CodyCBakerPhD
Copy link
Member Author

@h-mayorquin I think this is resolved now

Copy link
Collaborator

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this makes sense. Maybe we should add these to all the validate calls so no one needs to encounter this error if they decide to use a non pydantic type in the future.

I wish there was some kind of global configuration on this case or that we could call the validate decorator in the BaseDataInterface

@h-mayorquin h-mayorquin merged commit b01efeb into main Sep 6, 2024
35 checks passed
@h-mayorquin h-mayorquin deleted the pydantic_arrays branch September 6, 2024 21:57
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.32%. Comparing base (675ec48) to head (7b842c1).
Report is 61 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1055   +/-   ##
=======================================
  Coverage   90.32%   90.32%           
=======================================
  Files         129      129           
  Lines        7988     7991    +3     
=======================================
+ Hits         7215     7218    +3     
  Misses        773      773           
Flag Coverage Δ
unittests 90.32% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../ecephys/spikegadgets/spikegadgetsdatainterface.py 100.00% <100.00%> (ø)
...terfaces/ecephys/spikeglx/spikeglxnidqinterface.py 97.67% <100.00%> (+0.05%) ⬆️
...onv/datainterfaces/ophys/hdf5/hdf5datainterface.py 100.00% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants