-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pydantic IVb] Pydantic validation on arrays #1055
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@h-mayorquin I think this is resolved now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this makes sense. Maybe we should add these to all the validate calls so no one needs to encounter this error if they decide to use a non pydantic type in the future.
I wish there was some kind of global configuration on this case or that we could call the validate decorator in the BaseDataInterface
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1055 +/- ##
=======================================
Coverage 90.32% 90.32%
=======================================
Files 129 129
Lines 7988 7991 +3
=======================================
+ Hits 7215 7218 +3
Misses 773 773
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Follow up to add remaining validation calls for interfaces using arrays