Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default call to metadata in BaseRecordingInterface add_to_nwb method. #1012

Merged
merged 4 commits into from
Aug 16, 2024

Conversation

h-mayorquin
Copy link
Collaborator

As in the title.

Also, removed a deprecated option from the docstring.

@h-mayorquin h-mayorquin marked this pull request as ready for review August 15, 2024 16:27
@CodyCBakerPhD CodyCBakerPhD enabled auto-merge (squash) August 15, 2024 16:47
@CodyCBakerPhD CodyCBakerPhD merged commit e930ece into main Aug 16, 2024
35 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the base_recording_should_call_get_metadata branch August 16, 2024 14:52
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.23%. Comparing base (b9507bf) to head (944477a).
Report is 97 commits behind head on main.

Files with missing lines Patch % Lines
...erfaces/ecephys/baserecordingextractorinterface.py 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1012      +/-   ##
==========================================
- Coverage   91.43%   91.23%   -0.20%     
==========================================
  Files         127      127              
  Lines        7540     7564      +24     
==========================================
+ Hits         6894     6901       +7     
- Misses        646      663      +17     
Flag Coverage Δ
unittests 91.23% <50.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...erfaces/ecephys/baserecordingextractorinterface.py 95.87% <50.00%> (-0.97%) ⬇️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants