Fix for the cleanup_history task with a large number of parameters #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhoobin
force-pushed
the
fix_cleanup_helper_task
branch
3 times, most recently
from
07850e9 to
e54235b
Compare
|
Hi @nhoobin Just rebase this MR and I"ll review and merge it in |
PostgreSQL has a limit of 65535 parameters and this was exceeded causing the task to fail. MySQL has does not have a parameter limit, but there is a sysvar_max_allowed_packet which would fail out once exceeded.
nhoobin
force-pushed
the
fix_cleanup_helper_task
branch
from
e54235b to
930377b
Compare
|
Thanks for that. I'll cherry pick this and create a pull request for the new MOODLE_311 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PostgreSQL has a limit of 65535 parameters and this was exceeded causing the task to fail.
MySQL has does not have a parameter limit, but there is a sysvar_max_allowed_packet which would fail out once exceeded.