Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md for Minio.io Settings #590

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Update README.md for Minio.io Settings #590

merged 3 commits into from
Jan 22, 2024

Conversation

Frostist
Copy link
Contributor

@Frostist Frostist commented Jan 8, 2024

Added Minio.io Documentation as per my issue report. #579

Added Min.io Documentation as per my issue report.
#579
Added the correct lines to the table of contents.
@Frostist
Copy link
Contributor Author

Frostist commented Jan 9, 2024

As per my conversation found #579
and #374

I wanted to update the community to the fact they can use a 3rd party service like Min.io for a open source S3 bucket service.

@Frostist Frostist changed the title Update README.md Update README.md for Min.io Settings Jan 9, 2024
@Frostist Frostist changed the title Update README.md for Min.io Settings Update README.md for Minio.io Settings Jan 9, 2024
Updated spelling for Min.io to Minio.io
@danmarsden
Copy link
Member

Thanks for the PR!

I think before we approve this we should make it clearer in the readme what is "supported" vs what has been "tested as working"

Catalyst doesn't really "support" digital ocean or Min.io - we'd rely on community support for testing/fixing issues with using those.

@brendanheywood - that make sense to you too?

@Frostist
Copy link
Contributor Author

That's fair enough, I just thought it would be nice for users to see they can setup their own minio.io server and DYI the s3 storage instead of going the AWS or Google route.

Thanks!

@danmarsden
Copy link
Member

yeah I think it makes sense to add the details to the readme, I just don't like the title in the readme that suggests "we" support it directly - along with some other options that I don't think we really "support" ourselves.

@Frostist
Copy link
Contributor Author

Okay! Is there a different section of the readme where I could maybe put it then?

@danmarsden
Copy link
Member

nah - I think we probably need to adjust the section a bit on our end to make it clearer what "support" means - in particular we offer our code free to download, but don't actively test against all those in the list. I suspect Brendan is the best person to rewrite that section but if he doesn't jump in here I'll see if I can put something together sometime... :-)

@brendanheywood
Copy link
Contributor

Yeah and in hindsite I wish we gone with sub plugins so that all these other file stores can be managed by different maintainers in their own repo.

I think maybe have a 'supported' section vs 'community add ons', the first would be the things we personally use in production which is S3, Openstack and Azure but even that it murky as we may not be deploying those for all moodle stables.

@danmarsden
Copy link
Member

as a first step, I'm going to merge this in and just use github editing tools to update the readme a bit more to make it a little clearer that Catalyst doesn't fully "support" them directly.

@danmarsden danmarsden merged commit df65620 into catalyst:MOODLE_310_STABLE Jan 22, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants